-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone #2421
Merged
softwarefactory-project-zuul
merged 20 commits into
ansible-collections:main
from
alinabuzachis:route53_dnssec
Jan 17, 2025
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8580a53
Add route53_ksk module
alinabuzachis 5d5abe3
Add support for dnssec
alinabuzachis e10e6e7
Add changelog fragment
alinabuzachis 96fdc4a
Run black and isort
alinabuzachis ba8697d
Minor updates
alinabuzachis 99c81a9
Fix sanity
alinabuzachis 0b800ca
Update
alinabuzachis 8be9f64
Fix
alinabuzachis ba40a3a
Split into two PRs
alinabuzachis 2cfaaee
Apply suggested changes
alinabuzachis 1b5028d
Apply suggested changes
alinabuzachis ca4d58f
Modify upon review
alinabuzachis f8d098c
Modify upon review
alinabuzachis 1e09674
Use info from find_ksk
alinabuzachis b78ae26
Return info in check_mode
alinabuzachis 318d4b7
Update
alinabuzachis ac9d861
Apply suggestions
alinabuzachis 3e8ebf3
Modify upon review
alinabuzachis 823186a
Bring changes from route53
alinabuzachis e888025
Fixes
alinabuzachis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
minor_changes: | ||
- route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone (https://github.com/ansible-collections/amazon.aws/issues/1976). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added these comments to document what's happening if dnssec_status == "DELETING":.