Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump botocore requirement to 1.34.0 #2426

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Dec 19, 2024

SUMMARY

1.34 was released Nov 2023, 1.35 was released Aug 2024
Drops support for Python 3.7 (in line with botocore Python requirements)

Also fixes up the running the unit tests under tox.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/botocore.py

ADDITIONAL INFORMATION

With Python/botocore/awscli updates we no longer need to pin PyYAML, coverage and flake8

Copy link

github-actions bot commented Dec 19, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

This comment was marked as resolved.

@tremble tremble force-pushed the 10.0.0/botocore branch 2 times, most recently from e2c481b to 0545ea5 Compare December 19, 2024 14:32

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ef23ea4c10df416387fb5ac3c8d4e51c

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 10m 28s
✔️ ansible-test-splitter SUCCESS in 3m 56s
✔️ integration-amazon.aws-1 SUCCESS in 46m 16s
✔️ integration-amazon.aws-2 SUCCESS in 50m 01s
✔️ integration-amazon.aws-3 SUCCESS in 27m 38s
✔️ integration-amazon.aws-4 SUCCESS in 30m 29s
✔️ integration-amazon.aws-5 SUCCESS in 32m 47s
✔️ integration-amazon.aws-6 SUCCESS in 43m 16s
✔️ integration-amazon.aws-7 SUCCESS in 48m 54s
✔️ integration-amazon.aws-8 SUCCESS in 24m 25s
✔️ integration-amazon.aws-9 SUCCESS in 44m 10s
✔️ integration-amazon.aws-10 SUCCESS in 37m 18s
✔️ integration-amazon.aws-11 SUCCESS in 27m 23s
✔️ integration-amazon.aws-12 SUCCESS in 22m 27s
✔️ integration-amazon.aws-13 SUCCESS in 22m 38s
✔️ integration-amazon.aws-14 SUCCESS in 26m 34s
✔️ integration-amazon.aws-15 SUCCESS in 39m 22s
✔️ integration-amazon.aws-16 SUCCESS in 35m 59s
✔️ integration-amazon.aws-17 SUCCESS in 28m 37s
✔️ integration-amazon.aws-18 SUCCESS in 22m 13s
✔️ integration-amazon.aws-19 SUCCESS in 42m 21s
✔️ integration-amazon.aws-20 SUCCESS in 39m 13s
✔️ integration-amazon.aws-21 SUCCESS in 24m 09s
✔️ integration-amazon.aws-22 SUCCESS in 45m 09s
✔️ integration-community.aws-1 SUCCESS in 30m 33s
✔️ integration-community.aws-2 SUCCESS in 22m 43s
✔️ integration-community.aws-3 SUCCESS in 20m 00s
✔️ integration-community.aws-4 SUCCESS in 27m 49s
✔️ integration-community.aws-5 SUCCESS in 15m 37s
✔️ integration-community.aws-6 SUCCESS in 15m 38s
✔️ integration-community.aws-7 SUCCESS in 24m 16s
✔️ integration-community.aws-8 SUCCESS in 16m 39s
✔️ integration-community.aws-9 SUCCESS in 12m 37s
✔️ integration-community.aws-10 SUCCESS in 17m 13s
✔️ integration-community.aws-11 SUCCESS in 6m 25s
✔️ integration-community.aws-12 SUCCESS in 11m 40s
✔️ integration-community.aws-13 SUCCESS in 9m 56s
✔️ integration-community.aws-14 SUCCESS in 5m 09s
Skipped 8 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/bd649e966b194284b8fc636f21a737e8

✔️ ansible-galaxy-importer SUCCESS in 4m 55s
✔️ build-ansible-collection SUCCESS in 10m 33s
✔️ ansible-test-splitter SUCCESS in 4m 31s
✔️ integration-amazon.aws-1 SUCCESS in 47m 03s
✔️ integration-amazon.aws-2 SUCCESS in 51m 47s
✔️ integration-amazon.aws-3 SUCCESS in 23m 13s
✔️ integration-amazon.aws-4 SUCCESS in 28m 02s
✔️ integration-amazon.aws-5 SUCCESS in 32m 55s
✔️ integration-amazon.aws-6 SUCCESS in 42m 30s
✔️ integration-amazon.aws-7 SUCCESS in 52m 19s
✔️ integration-amazon.aws-8 SUCCESS in 24m 55s
✔️ integration-amazon.aws-9 SUCCESS in 45m 15s
✔️ integration-amazon.aws-10 SUCCESS in 47m 10s
✔️ integration-amazon.aws-11 SUCCESS in 29m 32s
✔️ integration-amazon.aws-12 SUCCESS in 24m 55s
✔️ integration-amazon.aws-13 SUCCESS in 23m 27s
✔️ integration-amazon.aws-14 SUCCESS in 29m 21s
✔️ integration-amazon.aws-15 SUCCESS in 38m 09s
✔️ integration-amazon.aws-16 SUCCESS in 35m 40s
✔️ integration-amazon.aws-17 SUCCESS in 24m 25s
✔️ integration-amazon.aws-18 SUCCESS in 22m 46s
✔️ integration-amazon.aws-19 SUCCESS in 40m 43s
integration-amazon.aws-20 FAILURE in 34m 53s
✔️ integration-amazon.aws-21 SUCCESS in 26m 23s
✔️ integration-amazon.aws-22 SUCCESS in 44m 52s
✔️ integration-community.aws-1 SUCCESS in 28m 03s
✔️ integration-community.aws-2 SUCCESS in 23m 22s
✔️ integration-community.aws-3 SUCCESS in 19m 14s
✔️ integration-community.aws-4 SUCCESS in 29m 36s
✔️ integration-community.aws-5 SUCCESS in 18m 13s
✔️ integration-community.aws-6 SUCCESS in 18m 53s
✔️ integration-community.aws-7 SUCCESS in 23m 27s
✔️ integration-community.aws-8 SUCCESS in 16m 38s
✔️ integration-community.aws-9 SUCCESS in 11m 33s
✔️ integration-community.aws-10 SUCCESS in 16m 16s
✔️ integration-community.aws-11 SUCCESS in 6m 35s
✔️ integration-community.aws-12 SUCCESS in 12m 01s
✔️ integration-community.aws-13 SUCCESS in 9m 00s
✔️ integration-community.aws-14 SUCCESS in 6m 21s
Skipped 8 jobs

@tremble
Copy link
Contributor Author

tremble commented Dec 23, 2024

recheck

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/cef02260d05944cda1c919f836a847ce

✔️ ansible-galaxy-importer SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 10m 43s
✔️ ansible-test-splitter SUCCESS in 4m 17s
✔️ integration-amazon.aws-1 SUCCESS in 46m 24s
✔️ integration-amazon.aws-2 SUCCESS in 50m 30s
✔️ integration-amazon.aws-3 SUCCESS in 26m 18s
✔️ integration-amazon.aws-4 SUCCESS in 31m 29s
✔️ integration-amazon.aws-5 SUCCESS in 36m 20s
✔️ integration-amazon.aws-6 SUCCESS in 48m 34s
✔️ integration-amazon.aws-7 SUCCESS in 44m 58s
✔️ integration-amazon.aws-8 SUCCESS in 26m 16s
✔️ integration-amazon.aws-9 SUCCESS in 46m 12s
✔️ integration-amazon.aws-10 SUCCESS in 38m 09s
✔️ integration-amazon.aws-11 SUCCESS in 26m 41s
✔️ integration-amazon.aws-12 SUCCESS in 26m 24s
✔️ integration-amazon.aws-13 SUCCESS in 25m 24s
✔️ integration-amazon.aws-14 SUCCESS in 26m 40s
✔️ integration-amazon.aws-15 SUCCESS in 42m 57s
✔️ integration-amazon.aws-16 SUCCESS in 34m 57s
✔️ integration-amazon.aws-17 SUCCESS in 24m 00s
✔️ integration-amazon.aws-18 SUCCESS in 25m 53s
✔️ integration-amazon.aws-19 SUCCESS in 39m 07s
✔️ integration-amazon.aws-20 SUCCESS in 37m 07s
✔️ integration-amazon.aws-21 SUCCESS in 30m 58s
✔️ integration-amazon.aws-22 SUCCESS in 44m 13s
✔️ integration-community.aws-1 SUCCESS in 31m 19s
✔️ integration-community.aws-2 SUCCESS in 23m 16s
✔️ integration-community.aws-3 SUCCESS in 18m 10s
✔️ integration-community.aws-4 SUCCESS in 26m 22s
✔️ integration-community.aws-5 SUCCESS in 17m 38s
✔️ integration-community.aws-6 SUCCESS in 17m 47s
✔️ integration-community.aws-7 SUCCESS in 24m 05s
✔️ integration-community.aws-8 SUCCESS in 15m 55s
✔️ integration-community.aws-9 SUCCESS in 13m 02s
✔️ integration-community.aws-10 SUCCESS in 17m 11s
✔️ integration-community.aws-11 SUCCESS in 8m 27s
✔️ integration-community.aws-12 SUCCESS in 10m 08s
✔️ integration-community.aws-13 SUCCESS in 10m 41s
✔️ integration-community.aws-14 SUCCESS in 5m 05s
Skipped 8 jobs

@tremble tremble requested a review from mandar242 December 23, 2024 21:15
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Dec 28, 2024
SUMMARY
1.34 was released Nov 2023, 1.35 was released Aug 2024
Also fixes up the running the unit tests under tox.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
requirements.txt
ADDITIONAL INFORMATION
See also: ansible-collections/amazon.aws#2426

Reviewed-by: Mandar Kulkarni <[email protected]>
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d4b6f4fc61014f4ebccaed9a870be78f

✔️ ansible-galaxy-importer SUCCESS in 5m 37s
✔️ build-ansible-collection SUCCESS in 10m 20s
✔️ ansible-test-splitter SUCCESS in 4m 32s
✔️ integration-amazon.aws-1 SUCCESS in 47m 40s
✔️ integration-amazon.aws-2 SUCCESS in 52m 28s
✔️ integration-amazon.aws-3 SUCCESS in 23m 36s
✔️ integration-amazon.aws-4 SUCCESS in 31m 44s
✔️ integration-amazon.aws-5 SUCCESS in 34m 18s
✔️ integration-amazon.aws-6 SUCCESS in 51m 31s
✔️ integration-amazon.aws-7 SUCCESS in 49m 52s
✔️ integration-amazon.aws-8 SUCCESS in 27m 21s
✔️ integration-amazon.aws-9 SUCCESS in 46m 07s
✔️ integration-amazon.aws-10 SUCCESS in 40m 23s
✔️ integration-amazon.aws-11 SUCCESS in 27m 15s
✔️ integration-amazon.aws-12 SUCCESS in 23m 13s
✔️ integration-amazon.aws-13 SUCCESS in 21m 03s
✔️ integration-amazon.aws-14 SUCCESS in 25m 00s
✔️ integration-amazon.aws-15 SUCCESS in 37m 45s
✔️ integration-amazon.aws-16 SUCCESS in 35m 38s
✔️ integration-amazon.aws-17 SUCCESS in 24m 39s
✔️ integration-amazon.aws-18 SUCCESS in 23m 47s
✔️ integration-amazon.aws-19 SUCCESS in 37m 23s
✔️ integration-amazon.aws-20 SUCCESS in 39m 32s
✔️ integration-amazon.aws-21 SUCCESS in 28m 42s
✔️ integration-amazon.aws-22 SUCCESS in 42m 58s
✔️ integration-community.aws-1 SUCCESS in 25m 38s
✔️ integration-community.aws-2 SUCCESS in 25m 03s
✔️ integration-community.aws-3 SUCCESS in 18m 03s
✔️ integration-community.aws-4 SUCCESS in 24m 10s
✔️ integration-community.aws-5 SUCCESS in 17m 42s
✔️ integration-community.aws-6 SUCCESS in 16m 08s
✔️ integration-community.aws-7 SUCCESS in 25m 10s
✔️ integration-community.aws-8 SUCCESS in 14m 47s
✔️ integration-community.aws-9 SUCCESS in 11m 14s
✔️ integration-community.aws-10 SUCCESS in 16m 01s
✔️ integration-community.aws-11 SUCCESS in 8m 18s
✔️ integration-community.aws-12 SUCCESS in 11m 46s
✔️ integration-community.aws-13 SUCCESS in 10m 13s
✔️ integration-community.aws-14 SUCCESS in 6m 03s
Skipped 8 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1226097e7e5f4fefae86abae4005ea9b

✔️ ansible-galaxy-importer SUCCESS in 5m 58s
✔️ build-ansible-collection SUCCESS in 10m 06s
✔️ ansible-test-splitter SUCCESS in 4m 05s
✔️ integration-amazon.aws-1 SUCCESS in 47m 58s
✔️ integration-amazon.aws-2 SUCCESS in 58m 09s
✔️ integration-amazon.aws-3 SUCCESS in 25m 59s
✔️ integration-amazon.aws-4 SUCCESS in 31m 43s
✔️ integration-amazon.aws-5 SUCCESS in 33m 10s
✔️ integration-amazon.aws-6 SUCCESS in 43m 32s
✔️ integration-amazon.aws-7 SUCCESS in 51m 25s
✔️ integration-amazon.aws-8 SUCCESS in 24m 39s
✔️ integration-amazon.aws-9 SUCCESS in 46m 46s
✔️ integration-amazon.aws-10 SUCCESS in 41m 47s
✔️ integration-amazon.aws-11 SUCCESS in 25m 30s
✔️ integration-amazon.aws-12 SUCCESS in 22m 45s
✔️ integration-amazon.aws-13 SUCCESS in 23m 37s
✔️ integration-amazon.aws-14 SUCCESS in 23m 43s
✔️ integration-amazon.aws-15 SUCCESS in 41m 10s
✔️ integration-amazon.aws-16 SUCCESS in 34m 18s
✔️ integration-amazon.aws-17 SUCCESS in 25m 32s
✔️ integration-amazon.aws-18 SUCCESS in 25m 48s
✔️ integration-amazon.aws-19 SUCCESS in 38m 40s
✔️ integration-amazon.aws-20 SUCCESS in 45m 13s
✔️ integration-amazon.aws-21 SUCCESS in 29m 23s
✔️ integration-amazon.aws-22 SUCCESS in 48m 11s
✔️ integration-community.aws-1 SUCCESS in 27m 30s
✔️ integration-community.aws-2 SUCCESS in 21m 16s
✔️ integration-community.aws-3 SUCCESS in 17m 29s
✔️ integration-community.aws-4 SUCCESS in 27m 16s
✔️ integration-community.aws-5 SUCCESS in 17m 36s
✔️ integration-community.aws-6 SUCCESS in 19m 23s
✔️ integration-community.aws-7 SUCCESS in 24m 37s
✔️ integration-community.aws-8 SUCCESS in 15m 23s
✔️ integration-community.aws-9 SUCCESS in 11m 47s
✔️ integration-community.aws-10 SUCCESS in 18m 05s
✔️ integration-community.aws-11 SUCCESS in 9m 12s
✔️ integration-community.aws-12 SUCCESS in 12m 17s
✔️ integration-community.aws-13 SUCCESS in 8m 37s
✔️ integration-community.aws-14 SUCCESS in 4m 56s
Skipped 8 jobs

@tremble tremble requested a review from abikouo January 7, 2025 09:39
@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Jan 7, 2025
@tremble tremble added this to the 10.0.0 milestone Jan 7, 2025
changelogs/fragments/botocore.yml Outdated Show resolved Hide resolved
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 7, 2025
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/74b3ce249dde4bbc9960c35944c31c27

✔️ ansible-galaxy-importer SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 10m 04s
✔️ ansible-test-splitter SUCCESS in 4m 13s
✔️ integration-amazon.aws-1 SUCCESS in 47m 46s
✔️ integration-amazon.aws-2 SUCCESS in 55m 14s
✔️ integration-amazon.aws-3 SUCCESS in 22m 30s
✔️ integration-amazon.aws-4 SUCCESS in 29m 45s
✔️ integration-amazon.aws-5 SUCCESS in 32m 46s
✔️ integration-amazon.aws-6 SUCCESS in 38m 55s
✔️ integration-amazon.aws-7 SUCCESS in 45m 14s
✔️ integration-amazon.aws-8 SUCCESS in 24m 12s
✔️ integration-amazon.aws-9 SUCCESS in 42m 51s
✔️ integration-amazon.aws-10 SUCCESS in 39m 47s
✔️ integration-amazon.aws-11 SUCCESS in 26m 17s
✔️ integration-amazon.aws-12 SUCCESS in 25m 49s
✔️ integration-amazon.aws-13 SUCCESS in 23m 29s
✔️ integration-amazon.aws-14 SUCCESS in 24m 21s
✔️ integration-amazon.aws-15 SUCCESS in 41m 17s
✔️ integration-amazon.aws-16 SUCCESS in 37m 09s
✔️ integration-amazon.aws-17 SUCCESS in 19m 08s
✔️ integration-amazon.aws-18 SUCCESS in 22m 43s
✔️ integration-amazon.aws-19 SUCCESS in 36m 52s
✔️ integration-amazon.aws-20 SUCCESS in 36m 22s
✔️ integration-amazon.aws-21 SUCCESS in 48m 06s
✔️ integration-amazon.aws-22 SUCCESS in 43m 35s
integration-community.aws-1 FAILURE in 51m 03s
✔️ integration-community.aws-2 SUCCESS in 23m 58s
✔️ integration-community.aws-3 SUCCESS in 15m 38s
✔️ integration-community.aws-4 SUCCESS in 23m 28s
✔️ integration-community.aws-5 SUCCESS in 20m 02s
✔️ integration-community.aws-6 SUCCESS in 18m 25s
✔️ integration-community.aws-7 SUCCESS in 24m 41s
✔️ integration-community.aws-8 SUCCESS in 15m 26s
✔️ integration-community.aws-9 SUCCESS in 11m 52s
✔️ integration-community.aws-10 SUCCESS in 17m 26s
✔️ integration-community.aws-11 SUCCESS in 8m 42s
✔️ integration-community.aws-12 SUCCESS in 10m 19s
✔️ integration-community.aws-13 SUCCESS in 8m 23s
✔️ integration-community.aws-14 SUCCESS in 4m 49s
Skipped 8 jobs

@tremble
Copy link
Contributor Author

tremble commented Jan 7, 2025

regate

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/7fe14fbd5c6f493d951924ce2c18854a

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 10m 03s
✔️ ansible-test-splitter SUCCESS in 3m 58s
✔️ integration-amazon.aws-1 SUCCESS in 44m 36s
✔️ integration-amazon.aws-2 SUCCESS in 51m 55s
✔️ integration-amazon.aws-3 SUCCESS in 24m 59s
✔️ integration-amazon.aws-4 SUCCESS in 34m 16s
✔️ integration-amazon.aws-5 SUCCESS in 32m 59s
✔️ integration-amazon.aws-6 SUCCESS in 40m 38s
✔️ integration-amazon.aws-7 SUCCESS in 47m 54s
✔️ integration-amazon.aws-8 SUCCESS in 25m 04s
✔️ integration-amazon.aws-9 SUCCESS in 45m 57s
✔️ integration-amazon.aws-10 SUCCESS in 40m 20s
✔️ integration-amazon.aws-11 SUCCESS in 28m 09s
✔️ integration-amazon.aws-12 SUCCESS in 22m 36s
✔️ integration-amazon.aws-13 SUCCESS in 22m 48s
✔️ integration-amazon.aws-14 SUCCESS in 25m 20s
✔️ integration-amazon.aws-15 SUCCESS in 39m 42s
✔️ integration-amazon.aws-16 SUCCESS in 33m 43s
✔️ integration-amazon.aws-17 SUCCESS in 28m 01s
✔️ integration-amazon.aws-18 SUCCESS in 25m 24s
✔️ integration-amazon.aws-19 SUCCESS in 38m 19s
✔️ integration-amazon.aws-20 SUCCESS in 36m 37s
✔️ integration-amazon.aws-21 SUCCESS in 27m 14s
✔️ integration-amazon.aws-22 SUCCESS in 45m 14s
✔️ integration-community.aws-1 SUCCESS in 28m 20s
✔️ integration-community.aws-2 SUCCESS in 22m 02s
✔️ integration-community.aws-3 SUCCESS in 18m 53s
✔️ integration-community.aws-4 SUCCESS in 26m 23s
✔️ integration-community.aws-5 SUCCESS in 15m 04s
✔️ integration-community.aws-6 SUCCESS in 18m 30s
✔️ integration-community.aws-7 SUCCESS in 25m 46s
✔️ integration-community.aws-8 SUCCESS in 16m 03s
✔️ integration-community.aws-9 SUCCESS in 11m 24s
✔️ integration-community.aws-10 SUCCESS in 17m 18s
✔️ integration-community.aws-11 SUCCESS in 8m 05s
✔️ integration-community.aws-12 SUCCESS in 12m 41s
✔️ integration-community.aws-13 SUCCESS in 10m 05s
✔️ integration-community.aws-14 SUCCESS in 5m 46s
Skipped 8 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b687bff into ansible-collections:main Jan 7, 2025
44 of 45 checks passed
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Jan 15, 2025
SUMMARY
1.34 was released Nov 2023, 1.35 was released Aug 2024
Drops support for Python 3.7 (in line with botocore Python requirements)
Also fixes up the running the unit tests under tox.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION
With Python/botocore/awscli updates we no longer need to pin PyYAML, coverage and flake8

Reviewed-by: Bikouo Aubin
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Jan 15, 2025
SUMMARY
1.34 was released Nov 2023, 1.35 was released Aug 2024
Drops support for Python 3.7 (in line with botocore Python requirements)
Also fixes up the running the unit tests under tox.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION
With Python/botocore/awscli updates we no longer need to pin PyYAML, coverage and flake8

Reviewed-by: Bikouo Aubin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do_not_backport This PR should not be backported to stable- branches unless absolutely necessary mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants