-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #2133/fa31438d backport][stable-8] fix(ec2_vol): output volume informations when volume exists in check mode #2437
Conversation
…mode (#2133) SUMMARY When using ec2_vol in check mode if the volume already exists and is attached, the module don't output the volume informations. This is problematic when used with a "register" directive when writing idempotent playbooks ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION Before : changed: false failed: false msg: 'IN CHECK MODE - volume already attached to instance: i-xxxxxxxxxxxxxxxxxxx.' After : attachments: - attach_time: '2024-05-17T15:14:49+00:00' delete_on_termination: false device: /dev/sdf instance_id: i-xxxxxxxxxxxxxxxxxxx state: attached volume_id: vol-xxxxxxxxxxxxxx availability_zone: eu-west-1a changed: false create_time: '2024-05-17T15:14:33.776000+00:00' encrypted: false failed: false iops: 3000 msg: 'IN CHECK MODE - volume already attached to instance: i-xxxxxxxxxxxxxxx.' multi_attach_enabled: false size: 30 snapshot_id: '' state: in-use tags: - key: Name value: xxxxxxxxxxxxxxxxxxxxxxxxxxxxx throughput: 125 volume_id: vol-xxxxxxxxxxxxxx volume_type: gp3 Reviewed-by: Alina Buzachis (cherry picked from commit fa31438)
Build failed.
|
recheck |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 57s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 34s |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This is a backport of PR #2133 as merged into main (fa31438).
SUMMARY
When using ec2_vol in check mode if the volume already exists and is attached, the module don't output the volume informations.
This is problematic when used with a "register" directive when writing idempotent playbooks
ISSUE TYPE
COMPONENT NAME
ec2_vol
ADDITIONAL INFORMATION
Before :
After :