-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework s3_bucket to use ErrorHandler model #2478
base: main
Are you sure you want to change the base?
Rework s3_bucket to use ErrorHandler model #2478
Conversation
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/s3_bucket_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/s3_bucket_module.html
index f24c2fb..d47bafd 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/s3_bucket_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/s3_bucket_module.html
@@ -223,6 +223,7 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-s3-bucke
</div></td>
<td><div class="ansible-option-cell"><p>The canned ACL to apply to the bucket.</p>
<p>If your bucket uses the bucket owner enforced setting for S3 Object Ownership, ACLs are disabled and no longer affect permissions.</p>
+<p>If <code class="ansible-option-value docutils literal notranslate"><a class="reference internal" href="#ansible-collections-amazon-aws-s3-bucket-module-parameter-public-access-ignore-public-acls"><span class="std std-ref"><span class="pre">public_access.ignore_public_acls=true</span></span></a></code> setting <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-s3-bucket-module-parameter-acl"><span class="std std-ref"><span class="pre">acl</span></span></a></strong></code> to a value other than <code class="ansible-value docutils literal notranslate"><span class="pre">private</span></code> may return success but not have an affect.</p>
<p class="ansible-option-line"><strong class="ansible-option-choices">Choices:</strong></p>
<ul class="simple">
<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">"private"</span></code></p></li>
|
6c42750
to
340c1e8
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 35s |
SUMMARY
s3_bucket has some support for non-AWS "S3" APIs, this PR reworks s3_bucket module to more consistently handle the various Errors that get thrown when the non-AWS-S3 API doesn't cleanly support some of the more advanced S3 features.
Our testing for non-AWS APIs is near non-existent, so it's important that the patterns displayed in the module are easy to follow and cleanly handle things a feature not being supported if someone doesn't try to use it.
Also fixes idempotency when setting the simplistic "templated" ACLs.
ISSUE TYPE
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION
I plan on migrating the remaining S3 modules in amazon.aws but this is just the first one.