Add a connection local deprecation warning #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KB-perByte
changed the title
NilashishC
reviewed
Aug 27, 2024
NilashishC
reviewed
Aug 28, 2024
NilashishC
reviewed
Aug 28, 2024
Qalthos
requested changes
Aug 28, 2024
NilashishC
reviewed
Aug 29, 2024
NilashishC
reviewed
Aug 29, 2024
Signed-off-by: NilashishC <[email protected]>
NilashishC
approved these changes
Aug 29, 2024
Signed-off-by: NilashishC <[email protected]>
Qalthos
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
[WARNING]: connection local support from netcommon is deprecated and will be removed at 01-01-2027Add warning for connection local!
ISSUE TYPE
COMPONENT NAME
percistent.py
ADDITIONAL INFORMATION
Notes -
_play_context.connection, because the connection would be network_cli even when the connection is local because we are redirecting to network_cli even when the connection is local ref_code