Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Update bgp_global.py #559

Closed
wants to merge 2 commits into from
Closed

Conversation

devogs
Copy link

@devogs devogs commented Oct 1, 2024

Incorrect Command Generation for ebgp_multihop in arista.eos.eos_bgp_neighbor Module.

line 267 is:

command += " ebgp-multiphop"

should be:

command += " ebgp-multihop"

Incorrect Command Generation for ebgp_multihop in arista.eos.eos_bgp_neighbor Module.

line 267 is:

command += " ebgp-multiphop"

should be:

command += " ebgp-multihop"
@Ruchip16
Copy link
Contributor

Ruchip16 commented Oct 9, 2024

@devogs can you please add some tests to validate the change and also add changelog?

Copy link
Contributor

@Ruchip16 Ruchip16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we already have a similar PR open for this which fixes this issue: #404

@Ruchip16
Copy link
Contributor

Ruchip16 commented Jan 7, 2025

closing this issue in favour of #404 as it addresses the exact issue and is merged now, thanks!

@Ruchip16 Ruchip16 closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants