Replace bool auto_neg with 4-option negotiation #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace bool auto_neg that always generates `no negotiation` lines when undefined - causing errors on S4148 running OS10 ver 10.5.3.4 as described in issue ansible-collections#133 Add negotiation parameter with "on", "off" or "auto" values that translate to ``` sw01(conf-if-eth1/1/1)# negotiation ? auto Automatic settings(default) on Negotiation is on off Negotiation is off ``` Undefined negotiation parameter should not generate any output to the resulting config to avoid failing on virtual interfaces (vlans, loopbackes, ...) that do not support negotiation ``` sw01(config)# interface vlan 100 sw01(conf-if-vl-100)# negotiation auto % Error: Unrecognized command. sw01(conf-if-vl-100)# no negotiation % Error: Unrecognized command. ```
|
thank you for this patch, applied it locally and it fixed 1.2.0 ; |
OS10 10.5.4 supports lag individual configuration for easier PXE booting support. https://www.dell.com/support/manuals/en-uk/dell-emc-smartfabric-os10/smartfabric-os-user-guide-10-5-3/lacp-individual?guid=guid-25378200-a76a-4575-b321-3550e57fad25&lang=en-us https://www.dell.com/support/manuals/en-uk/dell-emc-smartfabric-os10/smartfabric-os-user-guide-10-5-3/pxe-booting-use-case?guid=guid-9b40eb1a-c28c-4abd-8f47-8298d2476b49&lang=en-us Add support for this feature to the os10_lag role.
|
I am adding a new commit to "Add support for lag individual config" which is missing in the roles and it seems to be an important addition to the LAG role. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace bool auto_neg that always generates
no negotiationlines whenundefined - causing errors on S4148 running OS10 ver 10.5.3.4 as
described in issue #133
Add negotiation parameter with "on", "off" or "auto" values that
translate to
Undefined negotiation parameter should not generate any output to the
resulting config to avoid failing on virtual interfaces (vlans,
loopbackes, ...) that do not support negotiation
SUMMARY
Correct interface negotiation settings to be able to set all possible values or not setting any
value at all (for interfaces that do not support it).
Fixes #133.
ISSUE TYPE
COMPONENT NAME
role os10_interface
ADDITIONAL INFORMATION