Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add vm inventory #96

Merged

Conversation

mikemorency
Copy link
Collaborator

@mikemorency mikemorency commented Dec 30, 2024

SUMMARY

Adding a VM inventory plugin. Just like the ESXi inventory, this plugin is similar to the community version but changes a few things to be consistent with this repo's existing plugins/modules. Additionally, some options were removed because they were redundant or because the value added is questionable.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vms inventory plugin

ADDITIONAL INFORMATION

There are some minor changes to the ESXi plugin and base class as well. These changes are moving more redundant stuff out of the ESXi plugin and into the base class (so the VM plugin can also use it)

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 27.32558% with 125 lines in your changes missing coverage. Please review.

Project coverage is 28.23%. Comparing base (b50c216) to head (696bfa4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
plugins/inventory_utils/_base.py 23.80% 64 Missing ⚠️
plugins/inventory/vms.py 29.11% 56 Missing ⚠️
plugins/inventory/esxi_hosts.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   28.04%   28.23%   +0.19%     
==========================================
  Files          31       32       +1     
  Lines        2350     2440      +90     
  Branches      426      441      +15     
==========================================
+ Hits          659      689      +30     
- Misses       1691     1751      +60     
Flag Coverage Δ
sanity 28.23% <27.32%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemorency mikemorency force-pushed the feature/add-vm-inventory branch from a6a25ad to 8cd0407 Compare December 31, 2024 01:20
@mikemorency mikemorency force-pushed the feature/add-vm-inventory branch from 8cd0407 to 65d1614 Compare January 6, 2025 13:25
@mikemorency mikemorency merged commit 9eb9d27 into ansible-collections:main Jan 14, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants