-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add vm inventory #96
Merged
mikemorency
merged 2 commits into
ansible-collections:main
from
mikemorency:feature/add-vm-inventory
Jan 14, 2025
Merged
Feature/add vm inventory #96
mikemorency
merged 2 commits into
ansible-collections:main
from
mikemorency:feature/add-vm-inventory
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorency
requested review from
shellymiron,
elsapassaro,
prabinovRedhat,
anna-savina,
bardielle and
machacekondra
as code owners
December 30, 2024 01:45
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 28.04% 28.23% +0.19%
==========================================
Files 31 32 +1
Lines 2350 2440 +90
Branches 426 441 +15
==========================================
+ Hits 659 689 +30
- Misses 1691 1751 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mikemorency
force-pushed
the
feature/add-vm-inventory
branch
from
December 31, 2024 01:20
a6a25ad
to
8cd0407
Compare
mikemorency
force-pushed
the
feature/add-vm-inventory
branch
from
January 6, 2025 13:25
8cd0407
to
65d1614
Compare
anna-savina
approved these changes
Jan 14, 2025
machacekondra
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding a VM inventory plugin. Just like the ESXi inventory, this plugin is similar to the community version but changes a few things to be consistent with this repo's existing plugins/modules. Additionally, some options were removed because they were redundant or because the value added is questionable.
ISSUE TYPE
COMPONENT NAME
vms inventory plugin
ADDITIONAL INFORMATION
There are some minor changes to the ESXi plugin and base class as well. These changes are moving more redundant stuff out of the ESXi plugin and into the base class (so the VM plugin can also use it)