Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware collection maintainers #333

Conversation

mariolenz
Copy link
Collaborator

@goneri doesn't maintain vmware.vmware_rest any more. I'm afraid that, although some people are actively working on the collection and are preparing a new release, there are no named maintainers right now :-/

On the other hand, I'd like to add myself as the maintainer of community.vmware. Just realized this hasn't been documented yet.

Copy link

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mariolenz .

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The group ping is fine from my side. Let's quickly talk about this at today's community WG meeting.

@mariolenz
Copy link
Collaborator Author

The group ping is fine from my side. Let's quickly talk about this at today's community WG meeting.

Probably the same in #334

@mariolenz mariolenz requested a review from gotmax23 November 22, 2023 18:21
@felixfontein
Copy link
Contributor

@gotmax23 mentioned on Matrix that he doesn't like the team reference; he'll write something about that here later when he has time, we'll continue the discussion then.

@gotmax23
Copy link
Contributor

Yeah, I'm really not a fan of the team reference. It's not visible to non @ansible-collections members who is in that team, and we cannot directly ping that team from this repository.

@mariolenz
Copy link
Collaborator Author

Yeah, I'm really not a fan of the team reference. It's not visible to non @ansible-collections members who is in that team, and we cannot directly ping that team from this repository.

Better than documenting a wrong maintainer or nothing 🤷

@felixfontein
Copy link
Contributor

Yeah, I'm really not a fan of the team reference. It's not visible to non @ansible-collections members who is in that team, and we cannot directly ping that team from this repository.

I think not being able to ping them from this repository is OK, the main purpose is to be able to ping the maintainers on issues directly in their repository. Not being able to see the members of the team is more of a problem. This makes it impossible to directly take the current list of team members and ping them from here (if necessary).

I personally think it would be OK to allow teams in Ansible-owned organizations such as ansible-collections and ansible-network, since there we can ask the Community Team to ping internally (if we don't have access).

@mariolenz
Copy link
Collaborator Author

Not being able to see the members of the team is more of a problem. This makes it impossible to directly take the current list of team members and ping them from here (if necessary).

How about about documenting the maintainers as https://github.com/orgs/ansible-collections/teams/cloud? Or maybe ansible-collections/cloud (https://github.com/orgs/ansible-collections/teams/cloud)?

I really think the "we would prefer to not have to maintain a static list of staff in multiple places" argument is a pretty a good one.

@felixfontein
Copy link
Contributor

@felixfontein
Copy link
Contributor

Marking this PR and #334 as drafts.

@felixfontein felixfontein marked this pull request as draft November 24, 2023 21:43
@mariolenz mariolenz force-pushed the 20231122-vmware-collection-maintainers branch from e23c2f5 to 75d805d Compare December 6, 2023 19:38
@mariolenz mariolenz marked this pull request as ready for review December 7, 2023 19:22
Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think listing the team members manually is good for now. Thanks @mariolenz!

@gotmax23
Copy link
Contributor

gotmax23 commented Dec 7, 2023

@felixfontein, @Andersson007, can one of you give this a look also?

@felixfontein
Copy link
Contributor

I've commented on Matrix, I'd like to see a link to the GH team as a comment. That information is IMO the main source of truth, not that explicit list, so it should really be there.

@mariolenz mariolenz merged commit 61810bb into ansible-community:main Dec 7, 2023
3 of 4 checks passed
@mariolenz mariolenz deleted the 20231122-vmware-collection-maintainers branch December 7, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants