Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

molecule-vagrant: Improve network handling #99

Open
apatard opened this issue Feb 14, 2023 · 0 comments · May be fixed by #102
Open

molecule-vagrant: Improve network handling #99

apatard opened this issue Feb 14, 2023 · 0 comments · May be fixed by #102
Assignees
@apatard
Labels
vagrant

Comments

@apatard
Copy link
Member

apatard commented Feb 14, 2023

From a irc discussion, we should:
@apatard apatard self-assigned this Feb 14, 2023
apatard added a commit to apatard/molecule-plugins that referenced this issue Feb 15, 2023
@apatard
vagrant: Improve network interfaces support
26414b1 
Current code doesn't ensure that the network name is valid. According
to current Vagrant documentation, it can only be:
- public_network
- private_network
- forwarded_port

Moreover, the same documentation is saying that public network configuration
may be reduced to:

config.vm.network "public_network"

So add needed code to support interfaces without any options.

On the test side:
- modify the network test to check that the generated Vagrantfile is correct
when no option is specified
- add a test to ensure invalid network name are caught.

Fixes: ansible-community#99
Signed-off-by: Arnaud Patard <[email protected]>
@apatard apatard linked a pull request Feb 15, 2023 that will close this issue
Open
apatard added a commit to apatard/molecule-plugins that referenced this issue Mar 21, 2023
@apatard
vagrant: Improve network interfaces support
adb1b96 
Current code doesn't ensure that the network name is valid. According
to current Vagrant documentation, it can only be:
- public_network
- private_network
- forwarded_port

Moreover, the same documentation is saying that public network configuration
may be reduced to:

config.vm.network "public_network"

So add needed code to support interfaces without any options.

On the test side:
- modify the network test to check that the generated Vagrantfile is correct
when no option is specified
- add a test to ensure invalid network name are caught.

Fixes: ansible-community#99
Signed-off-by: Arnaud Patard <[email protected]>
apatard added a commit to apatard/molecule-plugins that referenced this issue Mar 21, 2023
@apatard
vagrant: Improve network interfaces support
cfbf530 
Current code doesn't ensure that the network name is valid. According
to current Vagrant documentation, it can only be:
- public_network
- private_network
- forwarded_port

Moreover, the same documentation is saying that public network configuration
may be reduced to:

config.vm.network "public_network"

So add needed code to support interfaces without any options.

On the test side:
- modify the network test to check that the generated Vagrantfile is correct
when no option is specified
- add a test to ensure invalid network name are caught.

Fixes: ansible-community#99
Signed-off-by: Arnaud Patard <[email protected]>
apatard added a commit to apatard/molecule-plugins that referenced this issue Apr 12, 2023
@apatard
vagrant: Improve network interfaces support
83cbd1b 
Current code doesn't ensure that the network name is valid. According
to current Vagrant documentation, it can only be:
- public_network
- private_network
- forwarded_port

Moreover, the same documentation is saying that public network configuration
may be reduced to:

config.vm.network "public_network"

So add needed code to support interfaces without any options.

On the test side:
- modify the network test to check that the generated Vagrantfile is correct
when no option is specified
- add a test to ensure invalid network name are caught.

Fixes: ansible-community#99
Signed-off-by: Arnaud Patard <[email protected]>
apatard added a commit to apatard/molecule-plugins that referenced this issue Apr 28, 2023
@apatard
vagrant: Improve network interfaces support
9c9ef27 
Current code doesn't ensure that the network name is valid. According
to current Vagrant documentation, it can only be:
- public_network
- private_network
- forwarded_port

Moreover, the same documentation is saying that public network configuration
may be reduced to:

config.vm.network "public_network"

So add needed code to support interfaces without any options.

On the test side:
- modify the network test to check that the generated Vagrantfile is correct
when no option is specified
- add a test to ensure invalid network name are caught.

Fixes: ansible-community#99
Signed-off-by: Arnaud Patard <[email protected]>
apatard added a commit to apatard/molecule-plugins that referenced this issue Jun 26, 2023
@apatard
vagrant: Improve network interfaces support
8be3b3e 
Current code doesn't ensure that the network name is valid. According
to current Vagrant documentation, it can only be:
- public_network
- private_network
- forwarded_port

Moreover, the same documentation is saying that public network configuration
may be reduced to:

config.vm.network "public_network"

So add needed code to support interfaces without any options.

On the test side:
- modify the network test to check that the generated Vagrantfile is correct
when no option is specified
- add a test to ensure invalid network name are caught.

Fixes: ansible-community#99
Signed-off-by: Arnaud Patard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apatard apatard

Labels
vagrant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vagrant: Improve network interfaces support apatard/molecule-plugins
1 participant
@apatard