vagrant: Improve network interfaces support #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apatard
force-pushed
the
vagrant_improve_interfaces
branch
2 times, most recently
from
adb1b96 to
cfbf530
Compare
apatard
force-pushed
the
vagrant_improve_interfaces
branch
from
cfbf530 to
83cbd1b
Compare
apatard
force-pushed
the
vagrant_improve_interfaces
branch
from
83cbd1b to
9c9ef27
Compare
Current code doesn't ensure that the network name is valid. According to current Vagrant documentation, it can only be: - public_network - private_network - forwarded_port Moreover, the same documentation is saying that public network configuration may be reduced to: config.vm.network "public_network" So add needed code to support interfaces without any options. On the test side: - modify the network test to check that the generated Vagrantfile is correct when no option is specified - add a test to ensure invalid network name are caught. Fixes: ansible-community#99 Signed-off-by: Arnaud Patard <[email protected]>
apatard
force-pushed
the
vagrant_improve_interfaces
branch
from
ff29149 to
8be3b3e
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code doesn't ensure that the network name is valid. According to current Vagrant documentation, it can only be:
Moreover, the same documentation is saying that public network configuration may be reduced to:
config.vm.network "public_network"
So add needed code to support interfaces without any options.
On the test side:
Fixes: #99