Add autocomplete=off to login form fields, password fields #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backport-4.7
|
tested in firefox, chrome |
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #4109 🤖 @patchback |
himdel
added a commit
that referenced
this pull request
Aug 11, 2023
…4109) * TextInput - add autoComplete=off to all password fields No-Issue * add and use a local copy of patternfly LoginForm * LoginForm - add autoComplete=off Issue: AAH-2625 * eslint - remove explicit any (cherry picked from commit 6dc75bd) Co-authored-by: Martin Hradil <[email protected]>
github-actions
bot
added
the
backported-4.7
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Aug 31, 2023
) * TextInput - add autoComplete=off to all password fields No-Issue * add and use a local copy of patternfly LoginForm * LoginForm - add autoComplete=off Issue: AAH-2625 * eslint - remove explicit any (cherry picked from commit 6dc75bd)
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Aug 31, 2023
) * TextInput - add autoComplete=off to all password fields No-Issue * add and use a local copy of patternfly LoginForm * LoginForm - add autoComplete=off Issue: AAH-2625 * eslint - remove explicit any (cherry picked from commit 6dc75bd)
This was referenced Aug 31, 2023
github-actions
bot
added
the
backported-4.6
github-actions
bot
added
the
backported-4.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AAH-2625
This PR:
LoginFormcomponent, to allow addingautoComplete=offautoComplete=offto both the username and password fields on the login form, to match Explicitly turn off autocomplete for API login form awx#14232autoComplete=offto any other password fields in forms(docs)