Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lib symlink to bwrap call #1312

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add lib symlink to bwrap call #1312

merged 2 commits into from
Nov 6, 2023

Conversation

christophert
Copy link
Contributor

Fixes #1310 by adding a /usr/lib to /lib symlink in calls to bwrap for sandboxing.

@christophert christophert requested a review from a team as a code owner October 2, 2023 19:28
@Akasurde
Copy link
Member

FYI this change is only required in case of aarch64

Shrews
Shrews approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Shrews Shrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem with this. It actually makes sense to symlink these dirs since we are already doing the lib64 variant.

@Shrews Shrews merged commit e81b02c into ansible:devel Nov 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shrews Shrews Shrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bwarp can't execute any binaries due to missing /lib symlink
3 participants
@christophert @Akasurde @Shrews