Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ActivityStream button at details page #2690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aeter
Copy link

@aeter aeter commented Jul 11, 2024

The current PR has the same fixes as this PR from the old user interface.

In short: at any "details" page (like, /access/organizations/1/details, /infrastructure/hosts/1/details, etc.) - if you click at the three dots at the top-right corner and choose View Activity Stream, it shows a generic activity stream for the category (organizations, hosts, etc.).

With the current PR, an __id parameter is added to the end of the Activity Stream query string, so the Activity Stream is filtered by host__id, orgranization__id, etc. - to the specific item.

Testing Done: tested locally

@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label Jul 11, 2024
@AlexSCorey
Copy link
Member

@aeter can you please push this pr directly to this repo instead of pushing it to a fork? Also, I want to call your attention to this pr which was just approved and provides some insight to the direction we are going with activity stream. #2706.

@AlexSCorey AlexSCorey requested a review from kialam July 15, 2024 13:38
@aeter aeter force-pushed the fix-activity-stream-buttons branch from 2a554d7 to efb9e71 Compare July 17, 2024 08:03
@aeter
Copy link
Author

aeter commented Jul 17, 2024

@AlexSCorey, @kialam : thank you very much! I was able to update the code, per the changed ActivityStream from the PR you linked.

As suggested, I tried to push a branch directly to the ansible-ui repo, but I don't have enough rights (I'm an external contributor, not from Red Hat).

So, I updated the current PR/branch, with my new code, and retested locally.
It can be merged without the need for github rights - if you think the code is ok.

@aeter
Copy link
Author

aeter commented Jul 22, 2024

This PR fixes/relates to this RedHat ticket

The code is probably not the best, but I'd be happy to improve it, if you have suggestions.
I answered the question regarding pushing to ansible/ansible-ui. To repeat, being an external contributor - I can open a PR only from my fork.
@kialam, @AlexSCorey - it seems there is some issue preventing us from moving forward with the code review and the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants