namespace list view with new api

[ShaiahWren]

[DO NOT MERGE- waiting on David's work on the ns api to be finished.]

This pr uses the new namespace api for the list and detail views. Additionally, it fixes the namespace create button for use with the correctly typed HubNamespace.

NOTES:

• I am using the Collection Version Search api with the new useCollectionVersionColumns hook.
• The namespace details tab is complete, as is its edit form, but patch and delete requests are not allowed yet on the api side, so saving forms will error.

Please use:
ansible/galaxy_ng#1705
pulp/pulp_ansible#1437

[himdel]

Might want to make this a draft before the API changes are merged and released?

[himdel]

I'm pretty sure we'll have to fix any type errors before merging instead of hiding them.
Otherwise, looks good 👍

EDIT: we'll try to make the typescript rules a bit more relaxed, will discuss on the next AAP meeting (7/11)

[ShaiahWren]

@himdel a little note on the typing errors... on lines 37 in NamespaceDetails.tsx the typing can't find 'results' or 'count' in the HubNamespace type, so it complains. Is this a case where typing can be loosened or do we have a different option for making tsc happier?

[himdel]

it should not be a problem in HubNamespace but in HubItemsResponse .. the API response you're getting back is not just the namespace, it's something like { data: the_namespace, meta: { count } } (maybe it's not data but results[0] but the point is the response is an object containing the namespace, not the namespace directly).

So .. likely the typing for the namespace itself is just fine, but HubItemsResponse assumes it will be in items and not data or results.

[MilanPospisil]

This looks like it returns only collections from published repo. And it uses old API, it should use new collection_versions API, like the old application. For example old hub calls in namespace detail:

http://localhost:8002/api/automation-hub/v3/plugin/ansible/search/collection-versions/?namespace=autohubtest2&repository_label=!hide_from_search&is_highest=true&offset=0&limit=10

I have this in my PR: #683
Approvals uses the collection_version API just like collection list.

Note that you need new key function, not the keyFn: idKeyFn, but something else, for example:
keyFn: (item) => item.collection_version.pulp_href + ':' + item.repository.name,

Its because idKeyFN returns id, but the new collection API not returns id, it return collection_version object and repository object. And collection pulp_href cannot be used by itself, because the same collection can be in multiple repos. Thus we add repo name to the key and make it unique.

Feel free to reach me when you have some questions!

[ShaiahWren]

@himdel yeah, you're right, thanks for looking at the typing:) I went ahead and created a new HubNamespaceResponse that works a lot better; I was able to push without applying the tsc ignore:) Lmk if this looks right

[nixocio]

Good job @ShaiahWren, minor suggestions.

[nixocio]

We are not passing down the _options prop, neither using the destructed variables. Remove?

Suggested change

	export function useCollectionVersionColumns(_options?: {
	export function useCollectionVersionColumns(

[nixocio]

Suggested change

	export interface HubNamespace {
	export interface HubNamespace {
	description?: string;
	company?: string;

[nixocio]

Using ItemsResponse seems to fix the typescript issues. I just looked at useGet usage in other contexts. Not sure if It is not addressing something in particular here.

[himdel]

you may want to replace this one with PulpItemsResponse from usePulpView - that matches the {count, results[], next?} format

[himdel]

see note above, but approving either way :)

[ShaiahWren]

@himdel @nixocio Thank you for your reviews and approvals:)
I can't merge this until David merges the /v3/namespaces work, but once he does, this will be good to go.:)

[himdel]

(this file will not be needed, use useHubView)

[himdel]

(remember to rebase, this file already exists on main, and the activeAutomationServer logic is obsolete)