Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress upgraded to v13.1.0 #883

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Cypress upgraded to v13.1.0 #883

merged 2 commits into from
Oct 5, 2023

Conversation

vidyanambiar
Copy link
Member

Version 13 of Cypress contains a new feature called 'Test Replay' which promises easy debugging of CI test failures in Cypress Cloud.

@vidyanambiar
Copy link
Member Author

vidyanambiar commented Sep 12, 2023 •
edited
Loading

This upgrade does not pass npm ci in the CI checks because of an unresolved peer dependency.
The package @4tw/[email protected] that we utilize for testing drag and drop functionality does not list cypress 13 as a peer dependency yet. However the @4tw/cypress-drag-drop repo has a merged PR as of 4 days ago to add Cypress 13 support. It's not released yet. I'm watching this PR comment for updates regarding when we can expect a new release.
In the meantime we could use npm ci with --force or --legacy-peer-deps. Or wait for @4tw/cypress-drag-drop's new release and update Cypress to v13 at that point.
Any recommendations?

@keithjgrant
Copy link
Member

Any recommendations?

I'd prefer to wait for the release rather than get in the habit of using --force or --legacy-peer-deps. I don't want to get stuck in a position where we could end up relying on those flags indefinitely if some dependency doesn't update

@keithjgrant
Copy link
Member

oh, it looks like the released that change with v2.2.5!

@vidyanambiar
Copy link
Member Author

@keithjgrant Thanks! I've updated@4tw/cypress-drag-drop to 2.2.5 👍

nixocio
nixocio approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexSCorey AlexSCorey merged commit 1793271 into main Oct 5, 2023
17 checks passed
@AlexSCorey AlexSCorey deleted the aap-15873 branch October 5, 2023 13:13
vidyanambiar added a commit that referenced this pull request Oct 5, 2023
@vidyanambiar
Revert "Cypress upgraded to v13.1.0 (#883)"
f25ee36 
This reverts commit 1793271.
@keithjgrant keithjgrant mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixocio nixocio nixocio approved these changes

@lgalis lgalis lgalis approved these changes

@keithjgrant keithjgrant Awaiting requested review from keithjgrant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vidyanambiar @keithjgrant @nixocio @lgalis @AlexSCorey