-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container level security context for task and web deployments #1728
base: devel
Are you sure you want to change the base?
Conversation
@gdasson Looks like this PR follows the plan laid out in this comment:
Changes suggested before merge:
|
917e2c2
to
596a0e1
Compare
@rooftopcellist : Thanks for the review and feedback. I have now incorporated your review comments. Thanks. |
@rooftopcellist or other reviewers : Any updates on this please? cc: @BharathDevopz |
Hello @gdasson, |
Quality Gate passedIssues Measures |
Hello, Any updates on this please? |
Hello, any updates on this please? Regarding the current security vulnerability https://nvd.nist.gov/vuln/detail/CVE-2024-53899 this would be a useful addition |
Hi, any updates? |
@djyasin : Rebased and fixed merge conflicts. Thanks. |
SUMMARY
The security context settings offered today only provide the option to set pod level security context for web and task deployments. This PR adds the option to allow container level security context for all of the containers under web and task deployments.
fixes: #1413
fixes: #890
fixes: #571
fixes: #383
This change doesn't dictate the values and let the users decide and configure the values on need basis. This makes it a safer approach to implement without breaking any functionality
ISSUE TYPE
ADDITIONAL INFORMATION
Two of the existing variable settings will become irrelevant after this change:
redis_capabilities
can be covered underredis_security_context_settings
after this changetask_privileged
can be covered undertask_security_context_settings
after this change