-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record the generation allowing for items to be patched #129
base: devel
Are you sure you want to change the base?
Conversation
Signed-off-by: Ryan Cook <[email protected]>
cc @rh-dluong This would allow all resources except for ansiblejob and ansibleworkflows to be modified. It will also mean that users can now make changes to a JobTemplate resource and it will consequently fire off the reconciliation loop and update the resource in AWX/Controller (potentially overwriting any changes made by users in the UI). On one hand, this was a bug all along, on the other hand, this could be perceived as unexpected behavior. I am curious about your thoughts. |
* Add AnsibleInventory CRD and inventory role * Lower max reconciles * Add CSV parameters Signed-off-by: Ryan Cook <[email protected]> Co-authored-by: Christian Adams <[email protected]> Co-authored-by: Roger Lopez <[email protected]>
Signed-off-by: Ryan Cook <[email protected]>
We need to think about how this works when the user has pre-created a resource with the same name in Controller already. Or if they change one of these managed resources in the UI for example after creation. Most people's expectation will probably be:
For example; extra_vars was specified by the user on a Job Template manually; but it isn't in the yaml definition of the resource I could see others wanted the behavior be to replace what is there and strictly adhere to configuration as code principles and only change the resource definitions in the yaml in SCM. So I think we should make it possible to do both; via a |
@rooftopcellist I prefer the CaC / GitOps approach; however, it would be nice to give users a choice. |
@cooktheryan @rooftopcellist what is the blocker in the above PR to merge? is the project still actively maintained ? we have similar use case of managing the resources via cac (gitops) approach, but with current setup it only creates, this doesn't update or delete |
Quality Gate passedIssues Measures |
This would provide for us a way to update resources once they have been applied and bypass the isFinished flag