fix project_update role/collection install

[bcoca]

• avoid looping
• avoid using multiple files, only one should be provided and processed per type
• use first_found and variables to locate existing file
• skip if no file exists

-->

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• Other

AWX VERSION

all

ADDITIONAL INFORMATION

[shanemcd]

It looks like project updates are failing with this change but the error handling in the smoke test isn't great

Exception: project_update 2 (failed) encountered an error (rc=None), please see task stdout for details.

It should be relatively trivial to spin up the dev env and see what's going on.

[AlanCoding]

In the current system, it installs all files. I'm not sure if it would be preferable to install just 1, when all are present. We need some better establishment of the requirements here.

[bcoca]

Yes, currently all files are used, i thought that was a bug, it seemed preferable to have a single file with all the info vs letting the user 'partition' the info across 4 files.

I have checked the few projects i have access to and none seems to use more than one file .. but i have no idea how representative that is.

[AlanCoding]

I agree with this, and want to ask @ffirg to look it over because it is a behavior change.

IMO, it's a sensible change and we should merge it along with #14081, and then use it as an opportunity to better document the policy for which requirements files get installed.

Changes:

• (this PR) if more than 1 requirements file is present under a folder (like roles/requirements.yml and roles/requirements.yaml) then only the 1st will be installed according to our precedence rules
• (other PR) if a root-level ./requirements.y[a]ml file is present then it will be installed with the ansible-galaxy install command

[AlanCoding]

Another change to the project update playbook has merged which is where the conflicts come from. I'm fine to make this change (although needs a release note) after a rebase. If you don't want to do the rebase, I can pick it up.

[bcoca]

i used the online editor, so i dont have a branch to rebase

[AlanCoding]

I rebased and pushed to your fork.

Your change was only previously applied to 2 tasks, but @john-westcott-iv's overlapping change turned those 2 tasks into 3 tasks, so your pattern was applied to that new "unified" requirements.yml task.

Also made small style changes to get all 3 tasks more consistent.

I think this is ready for review and testing.

[bcoca]

lgtm

[AlanCoding]

Getting some more data now:

The conditional check 'req_file is file' failed.
The error was:
  An unhandled exception occurred while templating '{{ req_candidates | first_found }}'.
  Error was a <class 'ansible.errors.AnsibleError'>, original message:
    template error while templating string: Could not load "first_found": 'first_found'.
    String: {{ req_candidates | first_found }}.
      Could not load "first_found": 'first_found'

The error appears to be in '/runner/project/project_update.yml': line 217, column 11, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

    - block:
        - name: Fetch galaxy roles from roles/requirements.(yml/yaml)
          ^ here

[AlanCoding]

https://docs.ansible.com/ansible/latest/collections/ansible/builtin/first_found_lookup.html

does

          vars:
            req_file: "{{ req_candidates | first_found }}"

need to be

          vars:
            req_file: "{{ lookup('ansible.builtin.first_found', req_candidates) }}"