Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hop node] documentation update in execution_nodes for hop nodes #14215

Merged
merged 8 commits into from
Jul 17, 2023

Conversation

thedoubl3j
Copy link
Member

SUMMARY

Fixes #14050

I attempted to make it as similar as the Adding Execution Nodes section above it but not sure if we want to add more context around how to do things or where to add them but for now, added the diagram and a little blurb about them.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Docs
AWX VERSION
devel
ADDITIONAL INFORMATION

@thedoubl3j thedoubl3j changed the title add diagram and supporting docs around hop nodes and what they are [hop node] documentation update in execution_nodes for hop nodes Jul 7, 2023
@thedoubl3j thedoubl3j requested a review from djyasin July 7, 2023 20:05
docs/execution_nodes.md Outdated Show resolved Hide resolved
@fosterseth
Copy link
Member

looks good so far, I think we want to add some details around the peers and peers_from_control_nodes fields (what they are, how to set them)

@thedoubl3j thedoubl3j requested a review from gundalow July 12, 2023 19:33
docs/execution_nodes.md Outdated Show resolved Hide resolved
docs/execution_nodes.md Outdated Show resolved Hide resolved
docs/execution_nodes.md Outdated Show resolved Hide resolved
docs/execution_nodes.md Outdated Show resolved Hide resolved
thedoubl3j and others added 2 commits July 14, 2023 11:30
@kurokobo
Copy link
Contributor

Thanks for updating the docs!

Since the new receptor-collection will no longer use the Copr repository (it will just download and extract binary from release page), shouldn't this line be removed?

Note, the playbook will enable the Copr ansible-awx/receptor repository so that Receptor can be installed.

@kurokobo
Copy link
Contributor

And as follow-up for #13287 and #13362, can you add a note for RHEL8-based nodes that describes receptor_dependencies in group_vars/all.yml should be modified to python39-pip instead of python3-pip?
The default python3-pip (updated in #14088) is applicable for only RHEL9, since python3-pip for RHEL8 is too old and causes error while install ansible-runner via pip.
Or should this be a different PR?

@thedoubl3j
Copy link
Member Author

@kurokobo I think we might move that to a separate issue since this is a feature branch. I will open an issue and copy over the info you have pasted here for it and tag you to confirm everything we want fixed.

@thedoubl3j thedoubl3j merged commit 0004a2a into ansible:feature_hop-node Jul 17, 2023
12 of 14 checks passed
fosterseth added a commit that referenced this pull request Jul 27, 2023
fosterseth added a commit that referenced this pull request Jul 27, 2023
fosterseth added a commit that referenced this pull request Jul 27, 2023
fosterseth added a commit that referenced this pull request Aug 1, 2023
fosterseth added a commit that referenced this pull request Aug 9, 2023
fosterseth added a commit that referenced this pull request Aug 24, 2023
fosterseth added a commit that referenced this pull request Aug 29, 2023
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants