Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hop node] fix failing ci checks on feature_hop-node branch #14226

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[hop node] fix failing ci checks on feature_hop-node branch #14226

merged 1 commit into from
Jul 13, 2023

Conversation

djyasin
Copy link
Member

@djyasin djyasin commented Jul 11, 2023

SUMMARY

Realted #14220

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION
22.3.1
ADDITIONAL INFORMATION

@github-actions github-actions bot added component:api component:awx_collection issues related to the collection for controlling AWX labels Jul 11, 2023
@djyasin
Copy link
Member Author

djyasin commented Jul 11, 2023 •
edited
Loading

Tests that need to be fixed on the feature branch:

  • api-test
  • api-swagger
  • api-schema
  • ui-lint
  • ui-test-screens
  • awx_collection sanity

@djyasin
Copy link
Member Author

djyasin commented Jul 11, 2023 •
edited by fosterseth
Loading

Tests that need to be fixed on the feature branch:

  • api-test
  • api-swagger
  • api-schema
  • ui-lint
  • ui-test-screens
  • awx_collection sanity

I believe api-schema is expected to fail since we made migration changes.

@AlanCoding
Copy link
Member

It is bizarre that the diff in https://github.com/ansible/awx/pull/13904/files doesn't show the changes that this reverts...

Looking at https://github.com/ansible/awx/pull/13904/commits, I actually see such a commit already landed db69f4b

I'm still not sure what's going on, I would say you might want to try rebasing the feature branch.

@djyasin
Copy link
Member Author

djyasin commented Jul 12, 2023

It is bizarre that the diff in https://github.com/ansible/awx/pull/13904/files doesn't show the changes that this reverts...

Looking at https://github.com/ansible/awx/pull/13904/commits, I actually see such a commit already landed db69f4b

I'm still not sure what's going on, I would say you might want to try rebasing the feature branch.

Thank you, Alan! I went ahead and rebased!

thedoubl3j
thedoubl3j approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sanity fix, lgtm

@djyasin djyasin force-pushed the fix_CI_tests_up_api-test_fails_14220 branch from a9b0b68 to 76452f4 Compare July 13, 2023 18:38
@fosterseth fosterseth marked this pull request as ready for review July 13, 2023 21:25
@fosterseth fosterseth merged commit fd30f4f into ansible:feature_hop-node Jul 13, 2023
12 of 14 checks passed
fosterseth pushed a commit that referenced this pull request Jul 27, 2023
@djyasin @fosterseth
[hop node] fix failing ci checks on feature_hop-node branch (#14226)
4b50c12
fosterseth pushed a commit that referenced this pull request Jul 27, 2023
@djyasin @fosterseth
[hop node] fix failing ci checks on feature_hop-node branch (#14226)
0a8d7f8
fosterseth pushed a commit that referenced this pull request Jul 27, 2023
@djyasin @fosterseth
[hop node] fix failing ci checks on feature_hop-node branch (#14226)
4599e78
fosterseth pushed a commit that referenced this pull request Aug 1, 2023
@djyasin @fosterseth
[hop node] fix failing ci checks on feature_hop-node branch (#14226)
310c049
fosterseth pushed a commit that referenced this pull request Aug 9, 2023
@djyasin @fosterseth
[hop node] fix failing ci checks on feature_hop-node branch (#14226)
3bd7a68
fosterseth pushed a commit that referenced this pull request Aug 24, 2023
@djyasin @fosterseth
[hop node] fix failing ci checks on feature_hop-node branch (#14226)
218e93a
fosterseth pushed a commit that referenced this pull request Aug 29, 2023
@djyasin @fosterseth
[hop node] fix failing ci checks on feature_hop-node branch (#14226)
6833976
djyasin added a commit to djyasin/awx that referenced this pull request Sep 16, 2024
@djyasin
[hop node] fix failing ci checks on feature_hop-node branch (ansible#…
bf3582a 
…14226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanCoding AlanCoding AlanCoding approved these changes

@fosterseth fosterseth fosterseth approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees
No one assigned
Labels
component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djyasin @AlanCoding @fosterseth @thedoubl3j