Touchup of PR body checks #14389
Merged
Touchup of PR body checks #14389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-westcott-iv
approved these changes
Aug 28, 2023
AlanCoding
commented
Aug 29, 2023
.github/workflows/pr_body_check.yml
Outdated
| @@ -7,6 +7,7 @@ on: | |||
| types: [opened, edited, reopened, synchronize] | |||
| jobs: | |||
| pr-check: | |||
| if: github.repository_owner == 'ansible' && github.repository == 'awx' | |||
There was a problem hiding this comment.
This was mistaken - the repository is "ansible/awx", so need to figure out how to deal with that.
AlanCoding
force-pushed
the
checks_revamp
branch
from
2b691e8
to
529e0f2
Compare
AlanCoding
force-pushed
the
checks_revamp
branch
from
529e0f2
to
fdae6de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This reverts #13839 because that is no longer the syntax we want to go with (either the ID in the title or the branch name or the commit) and it looks non-obvious how to do it the new way.
This also restricts the existing PR body check to just the AWX repo, because the issue / PR template is only relevant or desired for the AWX repo, and I don't want it to mess with either personal AWX forks or any organizational fork.
ISSUE TYPE
COMPONENT NAME