Remove extra scheduler state save that does nothing #14396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrod
approved these changes
Aug 30, 2023
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
While I was looking at #14394 I couldn't figure out what was happening, but I did find this one gigantic red flag.
This save seems to have been introduced in 13c89ab and it didn't make sense then either.
Between the two
state.save()calls, there is no change made to thestateobject. So what's the point of the save? The timestamp doesn't change from one to the other. The line just re-saves the existing data on the object and seems to be completely pointless.ISSUE TYPE
COMPONENT NAME