Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added relnotes for 23.0.0 #14409

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Added relnotes for 23.0.0 #14409

merged 1 commit into from
Sep 5, 2023

Conversation

tvo318
Copy link
Member

@tvo318 tvo318 commented Sep 5, 2023

SUMMARY

Adds release notes for 23.0.0 based on https://github.com/ansible/awx/releases/tag/23.0.0

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • Docs
AWX VERSION
23.0.0

@tvo318
Copy link
Member Author

tvo318 commented Sep 5, 2023

@oraNod - please, can you review this also? Thanks!

Copy link
Collaborator

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tvo318

@AlanCoding
Copy link
Member

Certainly no issues from me, but this appears to be a new process, and I want to make sure we make things as easy as possible for the future.

Shouldn't this be the same as what's shown here?

https://github.com/ansible/awx/releases/tag/23.0.0

We annotate tags (in the AWX release process) with a lightly sanitized history of commit messages. This is why we have tried to push for better summaries in PR titles (which will be the message after squashing). So I just want to ask if there's something here that should be hooked into that release process.

@tvo318
Copy link
Member Author

tvo318 commented Sep 5, 2023

@AlanCoding - The relnotes are the same as what you linked, but not verbatim. In addition to grammar, spelling, wordsmithing, etc., I've clarified some of them so they are more descriptive what the change was for so readers don't have to cross check in the PR itself to find out.
Having said that, we could either have one of the following processes:

  • Have better PR summaries before auto-gen of the relnotes and not rewrite them (developers only)
  • Not auto-generate the relnotes and have it done during this process instead (writer only)
  • Cleanup PR summaries before auto-gen and not have official release notes (writer only)
  • Have both - raw auto-gen list and official relnotes - the way we did it here (writer only)

@tvo318 tvo318 merged commit 4466976 into ansible:devel Sep 5, 2023
16 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants