collection bugfix booleans default value to match api

[sean-m-sullivan]

SUMMARY

collection bugfix booleans default value to match api
fixing issue
#14461

Also referencing
#14493

Also removes the tests folder from the final distribution tarball, I've seen a few instances where including it messes with sanity tests and others when collections like this are used as dependencies.

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• Collection

AWX VERSION

23.2.0

ADDITIONAL INFORMATION

[sean-m-sullivan]

I was not able to get a k8's up to make good tests for the instances, if you can suggest, or I can address it here tomorrow.

[AlanCoding]

This is going to set the enabled flag to true for any existing host where the option isn't specified.

[sean-m-sullivan]

you are right..........................................................................................................................................................................................................................................................................................................................................................................................................................................................

[AlanCoding]

I think we both have felt the same frustration with the sea-saw, whack-a-mole that comes of this. Partially just from the anger I feel from multiple experiences of this, I don't want to leave the problem un-fixed, and I don't want to let structural code issues block a fix for such a simple problem.

Your point here is well-taken. Today's fix should be more targeted, and avoid wading into the insanity of types of null. I've incorporated the spirit of your approach into #14493

Instead of marking the field deafults (which would mean maintaining more schema), that uses the module argument_spec data which already exists to know if something is a boolean field. It's still not totally correct, as I think diff_mode in schedules and workflow nodes may be a valid tertiary field in the API. However, I think that field serves a purpose that no one should want or care about, so I'd gladly accept this bug fix as a tradeoff.

[AlanCoding]

I'd rather not use this overall approach

[sean-m-sullivan]

I agree, this is just another can of worms in the long line of whack a mole, I don't think there is a great answer. Was thinking maybe we get the argument spec from the AAP API like I was thinking for enforced, but it still has that issue of if the user doesn't pass the field, it would default it.

Right now if anything is passed it honors it, and the API will skip that field, but I think the answer to this goes back to the enforced defaults idea.

I am trying to think of how we can make this better, and what criteria we would want on behavior of specifically host/shcedule state on

1. creation when no bool var is passed
2. Update/change not chaning where no var is passed for that bool field.

And focus on that behaving as expected, and how best to handle it.