Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt text for image directives in job_capacity.rst & job_slices.rst #14549

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Add alt text for image directives in job_capacity.rst & job_slices.rst #14549

merged 2 commits into from
Oct 20, 2023

Conversation

kishan3
Copy link
Contributor

@kishan3 kishan3 commented Oct 6, 2023

Fixes #14508

SUMMARY

Added alt test for image directives

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Docs

@kishan3
Copy link
Contributor Author

kishan3 commented Oct 10, 2023

Hi @tvo318 can you please check my PR if anything required?

@oraNod oraNod added the Hacktoberfest Issues tagged for Hacktoberfest label Oct 10, 2023
@oraNod
Copy link
Collaborator

oraNod commented Oct 10, 2023

Hi @kishan3 Thanks for the contribution!

Can you please amend your final commit to do the DCO signoff per the Contributor's Guide guidelines?

  1. git commit --signoff
  2. Push to your branch

@kishan3
Copy link
Contributor Author

kishan3 commented Oct 10, 2023

Hi @oraNod Thanks for the review.

Sorry for the silly question but it says nothing to commit when I run the command.

git commit --signoff
On branch 14501_add_alt_text
Your branch is ahead of 'origin/devel' by 5 commits.
  (use "git push" to publish your local commits)

nothing to commit, working tree clean

@kishan3
Copy link
Contributor Author

kishan3 commented Oct 12, 2023

Hi @oraNod just want to bring my last message back to your notice #14549 (comment)

@kishan3
Copy link
Contributor Author

kishan3 commented Oct 13, 2023

Hi @tvo318 @oraNod I updated PR with signoff commit.

@tvo318 tvo318 self-requested a review October 20, 2023 13:00
tvo318
tvo318 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@tvo318 tvo318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contributions, @kishan3 🎉

@tvo318 tvo318 enabled auto-merge (squash) October 20, 2023 13:12
@tvo318 tvo318 merged commit c4ab54d into ansible:devel Oct 20, 2023
20 checks passed
@kishan3 kishan3 deleted the 14508_add_alt_text branch October 21, 2023 03:44
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
@kishan3 @tvo318 @djyasin
Add alt text for image directives in job_capacity.rst & job_slices.rst (
6cd9c2f 
ansible#14549)

Co-authored-by: Kishan Mehta <[email protected]>
Co-authored-by: TVo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvo318 tvo318 tvo318 approved these changes

Assignees
No one assigned
Labels
community component:docs Hacktoberfest Issues tagged for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Add alt-text codeblock to Images for Userguide: job_capacity.rst and job_slices.rst
3 participants
@kishan3 @oraNod @tvo318