Support websocket per-endpoint auth #14879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* asyncio.gather expects *tasks .. gotta unpack the list
* Channels doesn't really give you an interface to support per-endpoint auth ... so this adds one. * The web browser and node <--> node communication have different auth needs.
11 tasks
TheRealHaoLiu
approved these changes
Feb 14, 2024
jbradberry
approved these changes
Feb 14, 2024
|
I would really appreciate it if changes like this actually came with tests to start with - even if the original change didn't get caught by a failing test it would be good to have a test now that would have failed before this fix. Saying "I'll add tests later" should mean "ok, we'll merge this PR when there are tests" |
|
@willthames that would ideal. I've added tests here https://github.com/ansible/awx/pull/14886/files I wasn't able to complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes node <--> node websocket auth
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
related to #14876