Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin django-ansible-base and add cronjob for updating django-ansible-base when new version releases #15364

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

chrismeyersfsu
Copy link
Member

@chrismeyersfsu chrismeyersfsu commented Jul 15, 2024

SUMMARY

Check django-ansible-base upstream for releases. If release does not match current pinned version in requirements/requirements_git.txt then make it match and open a PR with the match.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
devel
ADDITIONAL INFORMATION

Done:

  • Pin DAB in requirements_git.txt
  • Verify pinning DAB via requirements_git.txt works
  • Detect DAB version change via github API
  • Construct PR w/ DAB version pin changes
  • Submit PR to AWX
  • Bonus: Do not submit PR if there is already an open PR for the DAB release version
  • Run periodically via cron in github actions

Thoughts:
I wonder when/if unwanted PRs would be opened.

Run Init

  • Workflow ran and determined pinned version does not match upstream release
  • Branch bump-django-ansible-base created with upstream version
  • PR created

Run Again

  • Workflow ran via a force push with no changes.
  • Logs indicate that the PR workflow github action we are using sees that the PR hasn't changed and does nothing.

So it would seem it roughly behaves how we want it to. We do NOT want it to open a new PR every time the cron job runs.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 15, 2024
@chrismeyersfsu chrismeyersfsu marked this pull request as ready for review July 15, 2024 20:19
@TheRealHaoLiu TheRealHaoLiu changed the title Dab pin Pin django-ansible-base and add cronjob for updating django-ansible-base when new version releases Jul 16, 2024
@@ -0,0 +1,47 @@
---
name: DAB requirements update
on:

This comment was marked as resolved.

* Check upstream django-ansible-base releases. If the version upstream
  does not match the version we are pinned to then submit a PR with the
  upstream version.
@chrismeyersfsu chrismeyersfsu merged commit 22a491c into devel Jul 17, 2024
21 checks passed
@chrismeyersfsu chrismeyersfsu deleted the dab-pin branch July 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants