Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pytest CI error #15435

Merged
merged 1 commit into from
Aug 10, 2024

Commits on Aug 9, 2024

  1. Fixes pytest CI error

    ```
      /var/lib/awx/venv/awx/lib64/python3.11/site-packages/_pytest/python.py:163:
      PytestReturnNotNoneWarning: Expected None, but
      awx/main/tests/unit/test_tasks.py::TestJobCredentials::test_custom_environment_injectors_with_boolean_extra_vars
      returned ['successful', 0], which will be an error in a future version
      of pytest.  Did you mean to use `assert` instead of `return`?
    ```
    
    * Dug into the git blame for this one
      0605854 is the commit for any
      historians. It was wrongfully carried over from a mock pexpect
      implementation. Our new tests are nice. They don't go as far as trying
      to run the task so they do not need to mock pexpect. That is why it is
      safe to remove this code without finding it a new home.
    chrismeyersfsu committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d42d26e View commit details
    Browse the repository at this point in the history