-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new credential entry point discovery #15685
Open
thedoubl3j
wants to merge
8
commits into
ansible:devel
Choose a base branch
from
thedoubl3j:test-entrypoints
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
reviewed
Dec 11, 2024
Linked PR was merged. This looks all intended, but non-obvious conflicts with #15638 for rebase |
thedoubl3j
force-pushed
the
test-entrypoints
branch
3 times, most recently
from
December 17, 2024 18:39
e0353a2
to
007a760
Compare
- add logic to check what version of the project is running #rename temp_var, remove old code and add validation check
thedoubl3j
force-pushed
the
test-entrypoints
branch
from
December 19, 2024 20:12
d62e683
to
289209c
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In ansible/awx-plugins#68, managed and supported creds are introduced.
This PR updates our logic to load the correct bucket of creds depending on what is installed.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
This PR will not work until its corresponding PR is merged into awx-plugins but should be backwards compatible with the existing landscape of awx-plugins.