Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P.O.C: Manage Django Settings with Dynaconf #15702

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from
Draft

P.O.C: Manage Django Settings with Dynaconf #15702

wants to merge 1 commit into from

Conversation

rochacbruno
Copy link
Member

Dynaconf P.O.C

@github-actions github-actions bot added component:api dependencies Pull requests that update a dependency file labels Dec 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

AlanCoding
AlanCoding reviewed Dec 18, 2024
View reviewed changes
awx/settings/development_defaults.py

# del set_application_name

# settings.populate_obj(sys.modules[__name__])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a replacement for the commented code here? Is it possible to obtain these behaviors (like local_*.py) with dynaconf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ansible/awx/pull/15702/files#diff-7c44e0fb5f02a0b7ba5fc1d0e6b57da7b35edf564011c78e45d356343b8595b6R16-R33

AlanCoding
AlanCoding reviewed Dec 18, 2024
View reviewed changes
awx/settings/development_defaults.py

# Load default settings.
# from .defaults import * # NOQA
# from awx.settings.main import settings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this replaced by something else now - to have development / production inherit all the settings from default, with defaults coming at lower precedence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ansible/awx/pull/15702/files#diff-7c44e0fb5f02a0b7ba5fc1d0e6b57da7b35edf564011c78e45d356343b8595b6R16-R33

@AlanCoding
Copy link
Member

So how would the awx/conf (dynamic database backed settings) be handled with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanCoding AlanCoding AlanCoding left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:api dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rochacbruno @AlanCoding