Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Bundle CA Cert if provided #4

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Configure Bundle CA Cert if provided #4

merged 1 commit into from
Nov 9, 2023

Conversation

dsavineau
Copy link
Contributor

This adds a new parameter to the pulp CRD for specifying a secret resource that contains a bundle CA certificate value (under the bundle-ca.crt key.
The custom bundle CA certificate will be added to the trusted CA certificate database.

@dsavineau dsavineau marked this pull request as ready for review November 9, 2023 20:48
@rooftopcellist
Copy link
Member

@dsavineau we need to add the following to roles/common/defaults/main.yml

bundle_cacert_secret: ''

Otherwise, we will see this error when the user does not specify a CA bundle secret.

'bundle_cacert_secret' is undefined

This adds a new parameter to the pulp CRD for specifying a secret
resource that contains a bundle CA certificate value (under the
`bundle-ca.crt` key.
The custom bundle CA certificate will be added to the trusted CA
certificate database.

Signed-off-by: Dimitri Savineau <[email protected]>
@rooftopcellist
Copy link
Member

CI is failing because it is not fully set up yet in this new repo.

I tested this PR out and it works in both scenarios:

  • With a bundle_cacert_secret configured
  • With a vanilla Galaxy CR

CR tested:

---
apiVersion: pulp.pulpproject.org/v1beta1
kind: Pulp
metadata:
  name: galaxy
  namespace: galaxy
spec:
  # Test CA Bundle
  bundle_cacert_secret: my-custom-certs

  ingress_type: Route
  deployment_type: galaxy
  image: quay.io/pulp/galaxy-minimal
  image_version: 4.7.1
  image_web: quay.io/pulp/galaxy-web
  image_web_version: 4.7.1

@rooftopcellist rooftopcellist merged commit aaff984 into ansible:main Nov 9, 2023
0 of 5 checks passed
@dsavineau dsavineau deleted the add_bundle_ca_cert branch November 9, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants