-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update remote rh-certified default url #2032
Conversation
Are we backporting this or should those labels be removed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a system has already run this migration, it won't run it again if the file changed. I think it'd be better to make a new migration file which is sure to be run.
The intent in modifying an existing migration is so that only new installations will get the updated URL so that we don't impact customers who might have already modified it. |
A new migration file can do a conditional update by checking the current value. |
With the new migration file, we can remove the change in the old file right? Also, should the backport labels be removed? |
Backport to stable-4.9: 💚 backport PR created✅ Backport PR branch: Backported as #2077 🤖 @patchback |
AAP-15623 (cherry picked from commit 5b846b5)
Add /content/published to the default URL when setting up the default remotes. This has been fix on ansible#2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836
Add /content/published to the default URL when setting up the default remotes. This has been fix on ansible#2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836
Add /content/published to the default URL when setting up the default remotes. This has been fix on #2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836
Add /content/published to the default URL when setting up the default remotes. This has been fix on #2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836 (cherry picked from commit 5d56bdd)
… the correct URL for rh-certified (#2089) fix: Fresh installs must get the correct URL for rh-certified (#2078) Add /content/published to the default URL when setting up the default remotes. This has been fix on #2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836 (cherry picked from commit 5d56bdd) Co-authored-by: Bruno Rocha <[email protected]>
What is this PR doing:
AAP-15623
Reviewers must know:
PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit