Enable flake8-pytest-style plugin for ruff #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cutwater
force-pushed
the
feature/ruff/flake8-pytest-style
branch
5 times, most recently
from
dc9c9ad
to
e7107ef
Compare
Warnings fixed: * PT003 `scope='function'` is implied in `@pytest.fixture()` * PT006 Wrong type passed to first argument of `@pytest.mark.parametrize`; expected `tuple` * PT007 Wrong values type in `@pytest.mark.parametrize` expected `list` of `tuple` * PT011 `pytest.raises(ValueError)` is too broad, set the `match` parameter or use a more specific exception * PT013 Incorrect import of `pytest`; use `import pytest` instead * PT017 Found assertion on exception `e` in `except` block, use `pytest.raises()` instead * PT018 Assertion should be broken down into multiple parts * PT021 Use `yield` instead of `request.addfinalizer` Statistics: 26 PT003 [*] pytest-extraneous-scope-function 5 PT017 [ ] pytest-assert-in-except 3 PT006 [*] pytest-parametrize-names-wrong-type 2 PT007 [*] pytest-parametrize-values-wrong-type 2 PT021 [ ] pytest-fixture-finalizer-callback 1 PT011 [ ] pytest-raises-too-broad 1 PT013 [ ] pytest-incorrect-pytest-import 1 PT018 [ ] pytest-composite-assertion
cutwater
force-pushed
the
feature/ruff/flake8-pytest-style
branch
from
e7107ef
to
9e6f9de
Compare
|
jctanner
approved these changes
Oct 21, 2024
cutwater
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings fixed:
scope='function'is implied in@pytest.fixture()@pytest.mark.parametrize; expectedtuple@pytest.mark.parametrizeexpectedlistoftuplepytest.raises(ValueError)is too broad, set thematchparameter or use a more specific exceptionpytest; useimport pytestinsteadeinexceptblock, usepytest.raises()insteadyieldinstead ofrequest.addfinalizerStatistics: