eslint: no-unsafe-member-access (partial)

docs/usage-data.md

@@ -1,17 +1,17 @@
 # Data collection
 
-vscode-ansible has opt-in telemetry collection, provided by
+`vscode-ansible` has opt-in telemetry collection, provided by
 [vscode-redhat-telemetry](https://github.com/redhat-developer/vscode-redhat-telemetry).
 
 ## What's included in the vscode-ansible telemetry data
 
 - ansible-language-server start
-- errors during ansible-language-server start
+- errors during `ansible-language-server` start
 - any errors from LSP requests
 - Ansible core version
 - ansible-lint version if installed and enabled
-- ansible-playbook command runs successfully or fails.
-- ansible-navigator run command runs successfully or fails.
+- `ansible-playbook` command runs successfully or fails.
+- `ansible-navigator` run command runs successfully or fails.
 - Ansible vault (ansible-vault) command run in case it fails.
 - Resync Ansible inventory (ansible-inventory) command run in case it fails.
 - Execution environment enabled or disabled

eslint.config.mjs

@@ -15,12 +15,12 @@ const __dirname = path.dirname(__filename); // get the name of the directory
 
 export default tseslint.config(
   {
-    ignores: ["**/out/", ".yarn/*", "media/*"],
+    ignores: ["**/out/", ".yarn/*", "media/*", "site/*"],
   },
   {
     extends: [
       eslint.configs.recommended,
-      ...tseslint.configs.recommended,
+      ...tseslint.configs.recommended, // TODO: switch to strictTypeChecked
       prettierRecommendedConfig,
     ],
     files: [
@@ -52,6 +52,15 @@ export default tseslint.config(
       "@typescript-eslint/no-namespace": "error",
       "@typescript-eslint/no-non-null-assertion": "error",
       "@typescript-eslint/no-unused-vars": "error",
+      // Needed for tseslint.configs.strictTypeChecked
+      // "@typescript-eslint/require-await": "error",
+      // "@typescript-eslint/await-thenable": "error",
+      // "@typescript-eslint/unbound-method": "error",
+      // "@typescript-eslint/no-unsafe-member-access": "error",
+      // "@typescript-eslint/no-floating-promises": "error",
+      // "@typescript-eslint/restrict-template-expressions": "error",
+      // "@typescript-eslint/no-unsafe-argument": "error",
+      // "@typescript-eslint/no-unsafe-return": "error",
       // Fix temporary off/warn made during eslint v9 upgrade:
       "no-empty-function": "warn",
       "no-case-declarations": "off",

src/features/ansibleTox/controller.ts

@@ -206,9 +206,14 @@
           getTerminal(cwd, getRootParentLabelDesc(test)),
         );
         run.passed(test, Date.now() - start);
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      } catch (e: any) {
-        run.failed(test, new vscode.TestMessage(e.message), Date.now() - start);
+      } catch (e: unknown) {
+        let msg;
+        if (e instanceof Error) {
+          msg = e.message;
+        } else {
+          msg = `${e}`;
+        }
+        run.failed(test, new vscode.TestMessage(msg), Date.now() - start);
       }
     }
 

src/features/contentCreator/scaffoldCollectionPage.ts

@@ -5,7 +5,7 @@
 import * as os from "os";
 import { getUri } from "../utils/getUri";
 import { getNonce } from "../utils/getNonce";
-import { AnsibleCreatorInitInterface } from "./types";
+import { AnsibleCreatorInitInterface, PostMessageEvent } from "./types";
 import { withInterpreter } from "../utils/commandRunner";
 import { SettingsManager } from "../../settings";
 
@@ -306,11 +306,17 @@
     const ADEVersion = await this.getBinDetail("ade", "--version");
     if (ADEVersion === "failed") {
       // send the system details to the webview
-      webView.postMessage({ command: "ADEPresence", arguments: false });
+      webView.postMessage({
+        command: "ADEPresence",
+        arguments: false,
+      } as PostMessageEvent);
       return;
     }
     // send the system details to the webview
-    webView.postMessage({ command: "ADEPresence", arguments: true });
+    webView.postMessage({
+      command: "ADEPresence",
+      arguments: true,
+    } as PostMessageEvent);
     return;
   }
 
@@ -440,7 +446,7 @@
         collectionUrl: collectionUrl,
         status: ansibleCreatorCommandPassed,
       },
-    });
+    } as PostMessageEvent);
   }
 
   public async openLogFile(fileUrl: string) {

src/features/contentCreator/types.ts

@@ -10,3 +10,19 @@ export type AnsibleCreatorInitInterface = {
   isForced: boolean;
   isEditableModeInstall: boolean;
 };
+
+export type PostMessageEvent =
+  | {
+      command: "ADEPresence";
+      arguments: boolean;
+    }
+  | {
+      command: "execution-log";
+      arguments: {
+        commandOutput: string;
+        logFileUrl: string;
+        collectionUrl: string;
+        status: string;
+      };
+      data?: string;
+    };

src/features/utils/python.ts

@@ -22,18 +22,22 @@
 /** Get python interpreter details */
 export async function getInterpreterDetails(): Promise<IInterpreterDetails> {
   const pythonExtension = await activatePythonExtension();
-  const exports = await pythonExtension?.exports;
+  if (pythonExtension !== undefined) {
+    const exports = await pythonExtension.exports;
 
-  const environment = await exports?.environments.resolveEnvironment(
-    exports?.environments.getActiveEnvironmentPath(),
-  );
+    if (exports !== undefined) {
+      const environment = await exports?.environments.resolveEnvironment(
+        exports?.environments.getActiveEnvironmentPath(),
+      );
 
-  if (environment?.executable.uri) {
-    return {
-      path: environment?.executable.uri.fsPath,
-      environment: environment.environment?.name,
-      version: `${environment.version.major}.${environment.version.minor}.${environment.version.micro}`,
-    };
+      if (environment?.executable.uri) {
+        return {
+          path: environment?.executable.uri.fsPath,
+          environment: environment.environment?.name,
+          version: `${environment.version.major}.${environment.version.minor}.${environment.version.micro}`,
+        };
+      }
+    }
   }
   return {
     path: undefined,

src/features/vault.ts

@@ -45,7 +45,11 @@
 }
 
 function ansibleVaultPath(config: vscode.WorkspaceConfiguration): string {
-  return `${config.ansible.path || "ansible"}-vault`;
+  const path = config.get("ansible.path");
+  if (typeof path === "string") {
+    return `${path || "ansible"}-vault`;
+  }
+  return "ansible-vault";
 }
 
 export const toggleEncrypt = async (): Promise<void> => {

src/utils/telemetryUtils.ts

@@ -112,12 +112,10 @@
     isInitialized: boolean,
     errorMessage?: string,
   ): Promise<void> {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const startUpData: any = {
-      "ansible.server.initialized": isInitialized,
-    };
+    const startUpData: Map<string, string | boolean> = new Map();
+    startUpData.set("ansible.server.initialized", isInitialized);
     if (errorMessage) {
-      startUpData["error"] = errorMessage;
+      startUpData.set("error", errorMessage);
     }
     await this.sendTelemetry("startup", startUpData);
   }

src/webview/apps/contentCreator/scaffoldCollectionPageApp.ts

@@ -9,7 +9,10 @@ import {
   provideVSCodeDesignSystem,
   Dropdown,
 } from "@vscode/webview-ui-toolkit";
-import { AnsibleCreatorInitInterface } from "../../../features/contentCreator/types";
+import {
+  AnsibleCreatorInitInterface,
+  PostMessageEvent,
+} from "../../../features/contentCreator/types";
 
 provideVSCodeDesignSystem().register(allComponents);
 
@@ -185,17 +188,20 @@ function toggleEditableModeInstallCheckBox() {
     command: "check-ade-presence",
   });
 
-  window.addEventListener("message", (event) => {
-    const message = event.data; // The JSON data our extension sent
+  window.addEventListener(
+    "message",
+    (event: MessageEvent<PostMessageEvent>) => {
+      const message = event.data; // The JSON data our extension sent
 
-    if (message.command === "ADEPresence") {
-      if (message.arguments) {
-        editableModeInstall.disabled = false;
-      } else {
-        editableModeInstall.disabled = true;
+      if (message.command === "ADEPresence") {
+        if (message.arguments) {
+          editableModeInstall.disabled = false;
+        } else {
+          editableModeInstall.disabled = true;
+        }
       }
-    }
-  });
+    },
+  );
 }
 
 function handleInitClearClick() {
@@ -249,31 +255,37 @@ function handleInitCreateClick() {
     } as AnsibleCreatorInitInterface,
   });
 
-  window.addEventListener("message", async (event) => {
-    const message = await event.data;
-
-    switch (message.command) {
-      case "execution-log":
-        initLogsTextArea.value = message.arguments.commandOutput;
-        logFileUrl = message.arguments.logFileUrl;
-
-        if (logFileUrl) {
-          initOpenLogFileButton.disabled = false;
-        } else {
-          initOpenLogFileButton.disabled = true;
-        }
-
-        if (message.arguments.status && message.arguments.status === "passed") {
-          initOpenScaffoldedFolderButton.disabled = false;
-        } else {
-          initOpenScaffoldedFolderButton.disabled = true;
-        }
-
-        collectionUrl = message.arguments.collectionUrl;
-
-        return;
-    }
-  });
+  window.addEventListener(
+    "message",
+    async (event: MessageEvent<PostMessageEvent>) => {
+      const message = await event.data;
+
+      switch (message.command) {
+        case "execution-log":
+          initLogsTextArea.value = message.arguments.commandOutput;
+          logFileUrl = message.arguments.logFileUrl;
+
+          if (logFileUrl) {
+            initOpenLogFileButton.disabled = false;
+          } else {
+            initOpenLogFileButton.disabled = true;
+          }
+
+          if (
+            message.arguments.status &&
+            message.arguments.status === "passed"
+          ) {
+            initOpenScaffoldedFolderButton.disabled = false;
+          } else {
+            initOpenScaffoldedFolderButton.disabled = true;
+          }
+
+          collectionUrl = message.arguments.collectionUrl;
+
+          return;
+      }
+    },
+  );
 }
 
 function handleInitClearLogsClick() {