Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Playbook Project webview to use @vscode-elements package #1773

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Jan 21, 2025

This PR updates Ansible playbook project webview to use @vscode-elements/elements package
instead of now deprecated @vscode/webview-ui-toolkit.

Updated related code and styles and tests.

For https://github.com/vscode-elements package info refer: https://vscode-elements.github.io/guides/getting-started/

Related: AAP-37623

@shatakshiiii
Copy link
Contributor Author

Codecov is failing unexpectedly. These changes are updated in the UI test: "Test Ansible playbook and collection project scaffolding". This is a false positive.

Copy link
Contributor

@abhikdps abhikdps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it seems that clicking on the Clear All Button does not clear the text fields, i.e the Namespace and Collection fields are not getting cleared. Other than this, everything else looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants