Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples #28

Closed
wants to merge 24 commits into from
Closed

Add examples #28

wants to merge 24 commits into from

Conversation

Devin-Crawford
Copy link
Collaborator

Pull Request Template

Description

Please provide a brief description of the changes in this pull request.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have tested these changes locally and verified that they work as intended.
  • I have updated any documentation as needed to reflect these changes (if appropriate)
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.
  • Unit tests have been added (if appropriate)
  • Test-cases have been added (if appropriate)
  • Testing instructions have been added (if appropriate)

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Feb 26, 2024
@Devin-Crawford
Copy link
Collaborator Author

Closing for now to avoid tying up the runner.

@Devin-Crawford Devin-Crawford reopened this Mar 7, 2024
Note: Previous version was triggering a false positive in an
example.
@SMoraisAnsys
Copy link
Collaborator

@dcrawforAtAnsys Seems like we had a false positive with codespell and didn't moved to pyedb when instanciating EDB

Copy link
Collaborator Author

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: When trying to access the loop resistance, an error happens and
AEDT crashes which makes the example non ending.
Copy link
Collaborator Author

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys
Copy link
Collaborator

SMoraisAnsys commented Mar 8, 2024

@dcrawforAtAnsys I had to make a fix in Dcir_in_3DLayout.py (HFFS3DLayout) because the following call was failing.

loop_resistance = hfss3dl.get_dcir_element_data_loop_resistance(setup_name="my_setup")

This might be caused by our move into AEDT 2024.1 (in that case we have to tackle this problem in pyaedt) or it is simply a method that shouldn't be called in that context. However, since it makes AEDT crash, I strongly suggest that we tackle this problem in pyaedt. I'll open an issue on the repo.
After looking in pyaedt, it seems that this line of code was also removed when switching into version 2024.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants