feat: driving dimensions #1340

umutsoysalansys · 2024-08-02T17:45:49Z

Description

Bringing driving dimensions/ geometry parametrization to pyansys-geometry.

Issue linked

Checklist

I have tested my changes locally.
I have added necessary documentation or updated existing documentation.
I have followed the coding style guidelines of this project.
I have added appropriate unit tests.
I have reviewed my changes before submitting this pull request.
I have linked the issue or issues that are solved to the PR if any.
I have assigned this PR to myself.
I have added the minimum version decorator to any new backend method implemented.
I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

codecov · 2024-08-02T18:05:11Z

Codecov Report

Attention: Patch coverage is 73.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.68%. Comparing base (b1d6271) to head (0fae95a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ansys/geometry/core/parameters/parameters.py	73.68%	10 Missing ⚠️
src/ansys/geometry/core/designer/design.py	71.42%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   91.84%   91.68%   -0.16%     
==========================================
  Files          86       88       +2     
  Lines        6928     6988      +60     
==========================================
+ Hits         6363     6407      +44     
- Misses        565      581      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RobPasMue · 2024-08-05T07:37:10Z

Let's discuss this later @umutsoysalansys but I wouldn't have it as an independent module of the whole "design" structure. I think driving dimensions should be a property of bodies...

RobPasMue

Overall looks good @umutsoysalansys! I left some enhancement suggestions. Main missing point is an example. We need examples that demonstrates how to use these new features. This is part of the requested actions for any new implementation. Otherwise users won't know how to make use of it.

src/ansys/geometry/core/designer/design.py

src/ansys/geometry/core/parameters/parameter.py

src/ansys/geometry/core/designer/design.py

RobPasMue · 2024-10-16T06:56:39Z

tests/integration/test_design.py

+def test_design_parameters(modeler: Modeler):
+    """Test the design parameters functionality."""
+


Seems like the test is failing - do you know the reason? There seems to be some kind of issue with the server apparently... We are using the latest proto and servers to check this so... maybe a pending PR on the server side?

RobPasMue

Blocking merge until comments are solved/implemented and the example is added. Also, testing needs to pass.

Co-authored-by: Kathy Pippert <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>

…cs-deps group (#1624) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Roberto Pastor Muela <[email protected]>

Co-authored-by: pyansys-ci-bot <[email protected]>

umutsoysalansys · 2025-01-16T15:21:24Z

@RobPasMue wanted to retarget this to Blitz. Changing target from top bringing this state. Any recommendations to clean them up quickly, mostly mds and toml file as far as I can see?

RobPasMue · 2025-01-16T15:29:45Z

@RobPasMue wanted to retarget this to Blitz. Changing target from top bringing this state. Any recommendations to clean them up quickly, mostly mds and toml file as far as I can see?

Hmm hard one here IMO, because it's an old branch from main... You would be better off probably just creating a new branch and copy pasting the actual content of your PR onto it. That would be the quickest approach for sure

umutsoysalansys · 2025-01-16T20:38:33Z

This work is republished freshly into the blitzt branch. Keeping this as a draft reference for a while till the other one is being merged safely.

umutsoysalansys · 2025-01-21T05:26:07Z

Closing this one since same work is merged to Blitz branch.

umutsoysalansys added 2 commits July 31, 2024 00:59

get and set for driving dimensions

6ea7e85

Merge branch 'main' into feat/driving-dimensions

cf40188

github-actions bot added the enhancement New features or code improvements label Aug 2, 2024

chore: adding changelog file 1340.added.md

a1ae758

umutsoysalansys changed the title ~~Feat/driving dimensions~~ feat: driving dimensions Aug 2, 2024

chore: adding changelog file 1340.added.md

f7b7408

umutsoysalansys requested a review from smereu August 2, 2024 18:23

umutsoysalansys self-assigned this Aug 2, 2024

umutsoysalansys and others added 11 commits August 13, 2024 16:49

Merge branch 'main' into feat/driving-dimensions

43446c9

chore: adding changelog file 1340.added.md

f0445bd

contn

2d092ff

renaming

61bc06f

merge commit

cf07838

change file names

f98afd4

chore: adding changelog file 1340.added.md

bbe941e

Merge branch 'main' into feat/driving-dimensions

3f91e63

Merge branch 'main' into feat/driving-dimensions

9b71ccb

parameter updated

0fae95a

unit test for parameters

7fad5ca

umutsoysalansys requested a review from b-matteo October 15, 2024 18:57

refactor

a9ae7ae

umutsoysalansys marked this pull request as ready for review October 16, 2024 02:25

umutsoysalansys requested a review from a team as a code owner October 16, 2024 02:25

umutsoysalansys requested a review from RobPasMue October 16, 2024 02:25

Merge branch 'main' into feat/driving-dimensions

d59a102

RobPasMue reviewed Oct 16, 2024

View reviewed changes

RobPasMue requested changes Oct 16, 2024

View reviewed changes

review refactor

d0a75c0

umutsoysalansys and others added 7 commits November 13, 2024 08:35

Update src/ansys/geometry/core/parameters/parameter.py

59416c8

Co-authored-by: Kathy Pippert <[email protected]>

Update tests/integration/test_design.py

1f7edbb

Co-authored-by: Kathy Pippert <[email protected]>

Update src/ansys/geometry/core/parameters/parameter.py

86e28ca

Co-authored-by: Kathy Pippert <[email protected]>

Update src/ansys/geometry/core/parameters/parameter.py

3b46ae3

Co-authored-by: Kathy Pippert <[email protected]>

chore: auto fixes from pre-commit hooks

9c427e1

Update src/ansys/geometry/core/parameters/parameter.py

bb2b7b1

Co-authored-by: Kathy Pippert <[email protected]>

Update src/ansys/geometry/core/parameters/parameter.py

ba914b2

Co-authored-by: Kathy Pippert <[email protected]>

umutsoysalansys marked this pull request as draft November 13, 2024 14:37

auto-merge was automatically disabled November 13, 2024 14:37
Pull request was converted to draft

umutsoysalansys and others added 2 commits November 13, 2024 08:37

Update src/ansys/geometry/core/parameters/parameter.py

2dd5169

Co-authored-by: Kathy Pippert <[email protected]>

Update src/ansys/geometry/core/parameters/parameter.py

9d575bf

Co-authored-by: Kathy Pippert <[email protected]>

umutsoysalansys marked this pull request as ready for review November 13, 2024 14:39

umutsoysalansys and others added 9 commits November 15, 2024 07:54

Merge branch 'main' into feat/driving-dimensions

4f8ea14

Merge branch 'main' into feat/driving-dimensions

31045e1

build: bump ansys-api-geometry from 0.4.25 to 0.4.26 (#1626)

62cf15e

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>

build: bump scipy from 1.15.0 to 1.15.1 (#1625)

4405b4a

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>

build: bump ansys-sphinx-theme[autoapi] from 1.2.4 to 1.2.6 in the do…

f08c24e

…cs-deps group (#1624) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>

chore: pre-commit automatic update (#1630)

5a555e5

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Roberto Pastor Muela <[email protected]>

fix: FAQ on install (#1631)

1481c36

Co-authored-by: pyansys-ci-bot <[email protected]>

Merge branch 'main' into feat/driving-dimensions

82b46b0

chore: auto fixes from pre-commit hooks

1f40f80

umutsoysalansys changed the base branch from main to blitz January 16, 2025 15:19

doc clean up

31365df

umutsoysalansys marked this pull request as draft January 16, 2025 20:37

PipKat mentioned this pull request Jan 20, 2025

feat: parameters refurbished #1647

Merged

9 tasks

umutsoysalansys closed this Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: driving dimensions #1340

feat: driving dimensions #1340

umutsoysalansys commented Aug 2, 2024 •

edited

Loading

codecov bot commented Aug 2, 2024 •

edited

Loading

RobPasMue commented Aug 5, 2024

RobPasMue left a comment •

edited

Loading

RobPasMue Oct 16, 2024

RobPasMue left a comment

umutsoysalansys commented Jan 16, 2025 •

edited

Loading

RobPasMue commented Jan 16, 2025 •

edited

Loading

umutsoysalansys commented Jan 16, 2025

umutsoysalansys commented Jan 21, 2025

		def test_design_parameters(modeler: Modeler):
		"""Test the design parameters functionality."""

feat: driving dimensions #1340

feat: driving dimensions #1340

Conversation

umutsoysalansys commented Aug 2, 2024 • edited Loading

Description

Issue linked

Checklist

codecov bot commented Aug 2, 2024 • edited Loading

Codecov Report

RobPasMue commented Aug 5, 2024

RobPasMue left a comment • edited Loading

Choose a reason for hiding this comment

RobPasMue Oct 16, 2024

Choose a reason for hiding this comment

RobPasMue left a comment

Choose a reason for hiding this comment

umutsoysalansys commented Jan 16, 2025 • edited Loading

RobPasMue commented Jan 16, 2025 • edited Loading

umutsoysalansys commented Jan 16, 2025

umutsoysalansys commented Jan 21, 2025

umutsoysalansys commented Aug 2, 2024 •

edited

Loading

codecov bot commented Aug 2, 2024 •

edited

Loading

RobPasMue left a comment •

edited

Loading

umutsoysalansys commented Jan 16, 2025 •

edited

Loading

RobPasMue commented Jan 16, 2025 •

edited

Loading