Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reactivate test on failing extra edges test #1396

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

RobPasMue
Copy link
Member

Description

Verifying resolution of failing test for extra edges.

Issue linked

Closes #1335

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Sep 3, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner September 3, 2024 11:27
@RobPasMue RobPasMue linked an issue Sep 3, 2024 that may be closed by this pull request
@RobPasMue
Copy link
Member Author

@umutsoysalansys - please investigate on the server side why this test is failing and resolve. PR will test it on CI/CD.

@github-actions github-actions bot added the bug Something isn't working label Sep 3, 2024
@RobPasMue
Copy link
Member Author

Pinging @b-matteo and @smereu - this requires resolution

@umutsoysalansys
Copy link
Contributor

umutsoysalansys commented Sep 3, 2024

Because file is created in acis and changed as parasolid file docx. So it needs to be recreated.

@RobPasMue
Copy link
Member Author

Because file is created in acis and changed as parasolid file docx. So it needs to be recreated.

Can you recreate it and fix it @umutsoysalansys?

@umutsoysalansys
Copy link
Contributor

@umutsoysalansys - please investigate on the server side why this test is failing and resolve. PR will test it on CI/CD.

because apparently file is created in acis and saved as parasolid, or vice versa.

Because file is created in acis and changed as parasolid file docx. So it needs to be recreated.

Can you recreate it and fix it @umutsoysalansys?

I can but this is not on my priority list.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (0d7aac8) to head (c75864a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
+ Coverage   91.34%   91.44%   +0.09%     
==========================================
  Files          87       87              
  Lines        7131     7131              
==========================================
+ Hits         6514     6521       +7     
+ Misses        617      610       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue
Copy link
Member Author

Issue fixed - merging!

@RobPasMue RobPasMue merged commit 86a099d into main Jan 20, 2025
60 checks passed
@RobPasMue RobPasMue deleted the fix/extra-edges-test-failing branch January 20, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test on fixing extra edges (for Geometry Service)
3 participants