-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reactivate test on failing extra edges test #1396
Conversation
@umutsoysalansys - please investigate on the server side why this test is failing and resolve. PR will test it on CI/CD. |
Because file is created in acis and changed as parasolid file docx. So it needs to be recreated. |
Can you recreate it and fix it @umutsoysalansys? |
because apparently file is created in acis and saved as parasolid, or vice versa.
I can but this is not on my priority list. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
+ Coverage 91.34% 91.44% +0.09%
==========================================
Files 87 87
Lines 7131 7131
==========================================
+ Hits 6514 6521 +7
+ Misses 617 610 -7 ☔ View full report in Codecov by Sentry. |
Issue fixed - merging! |
Description
Verifying resolution of failing test for extra edges.
Issue linked
Closes #1335
Checklist
feat: extrude circle to cylinder
)