Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename object #1648

Merged
merged 33 commits into from
Jan 20, 2025
Merged

feat: rename object #1648

merged 33 commits into from
Jan 20, 2025

Conversation

jacobrkerstetter
Copy link

Description

Implemented the call to rename object and added the appropriate unit test
Reinstated the _clear_cached_bodies method to keep client and server in sync

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

jkerstet added 7 commits January 15, 2025 09:30
wip
eae158e
wip, failing test
ee2299f
test written - not passing
4752da5
rename_object fully implemented
7914676
Merge branch 'blitz' of https://github.com/ansys/pyansys-geometry int…
08d073a 
…o feat/jacob_rename_object

# Conflicts:
#	src/ansys/geometry/core/designer/geometry_commands.py
#	tests/integration/test_geometry_commands.py
fixing conflicts and repushing
bcaa5fb
adding decorators
b8fa7f9
@jacobrkerstetter jacobrkerstetter self-assigned this Jan 16, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner January 16, 2025 21:24
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 16, 2025
RobPasMue
RobPasMue requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes..

src/ansys/geometry/core/designer/geometry_commands.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/designer/geometry_commands.py Outdated Show resolved Hide resolved
jkerstet and others added 3 commits January 17, 2025 08:22
fixed documentation
c3d05c1 
fixed input to take list[str]
Merge branch 'feat/jacob_rename_object' of https://github.com/ansys/p…
4b9ce29 
…yansys-geometry into feat/jacob_rename_object

# Conflicts:
#	src/ansys/geometry/core/designer/geometry_commands.py
#	tests/integration/test_geometry_commands.py
@pre-commit-ci
chore: auto fixes from pre-commit hooks
c3e4966
@jonahrb jonahrb requested a review from RobPasMue January 17, 2025 18:53
RobPasMue
RobPasMue approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) January 20, 2025 16:13
@RobPasMue RobPasMue merged commit 85dcb8b into blitz Jan 20, 2025
25 of 27 checks passed
@RobPasMue RobPasMue deleted the feat/jacob_rename_object branch January 20, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umutsoysalansys umutsoysalansys umutsoysalansys left review comments

@jonahrb jonahrb jonahrb left review comments

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jacobrkerstetter jacobrkerstetter

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jacobrkerstetter @RobPasMue @jonahrb @umutsoysalansys @pyansys-ci-bot