Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tonality ECMA418-2 #208
base: main
Are you sure you want to change the base?
feat: Tonality ECMA418-2 #208
Changes from 4 commits
5394a94
53643e1
9e20989
b846b13
6df6af7
095a4d1
f2a48dd
7b99c20
32ba270
ea987fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-bouth why not sharing X axis?
On the plot you share in the description of the PR, X axes are both vs time, but slightly not synchronized, which looks weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by the way, isn't the same time scale (get_time_scale()) shared by both curves ?
If yes: we can use the same, and share it among both plots
If no: why ? and in this case, we probably miss a time_scale getter for the second one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anshlachamb I think the question is for me rather than for Antoine
The answer is because both output does not have exactly the same time scale (same behaviour as in SAS)
Concerning the "why" : I have no precise answer. As for the getter I don't know if it's needed, I leave that question to @ansaminard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"why": I don't know either, I planned to look into the Matlab code, but haven't the chance to do it yet. Anyway, whatever I find there, I doubt it'll have an immediate impact here, since @a-bouth says it's also the case in SAS