Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/yuanrui/json #213

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Feat/yuanrui/json #213

wants to merge 34 commits into from

Conversation

zhang-yuanrui
Copy link
Collaborator

@zhang-yuanrui zhang-yuanrui commented Dec 26, 2024

Error checking newly added in this PR includes:

  1. JSON decode error: the input file does not follow the correct format.
  2. If template ID following the naming convention, like, "Template_0", so is the naming under "parent" and "children" entries.
  3. If the number of keys (missing keys) and key names match the schema.
  4. If the "report_type" falls in the given number of types.
  5. If "item_filter" follows the given rule.

Error handling and feedback:
Once the error happens, a prompt will pop up providing the detailed information to help the user understand what happens and debug.

Known but not done yet in this PR:
Check 'sort_selection' and 'params' - lack of necessary requirements

Edit:
Added 2 new features per comments and requests:

  1. Drop "date".
  2. Add an optional logger parameter to "load_templates" method.

@zhang-yuanrui zhang-yuanrui added the enhancement New feature or request label Dec 26, 2024
@zhang-yuanrui zhang-yuanrui marked this pull request as ready for review December 26, 2024 17:48
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 93.87755% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (b0b1a61) to head (195ed03).

Files with missing lines Patch % Lines
...ynamicreporting/core/utils/report_remote_server.py 93.81% 1 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   60.54%   60.82%   +0.27%     
==========================================
  Files          22       22              
  Lines        6702     6751      +49     
  Branches     1280     1297      +17     
==========================================
+ Hits         4058     4106      +48     
  Misses       2269     2269              
- Partials      375      376       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@margalva margalva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants