Add script to run interrupt command #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vel/interrupt-example
for more information, see https://pre-commit.ci
Wiz Scan Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 93.71% 93.91% +0.20%
==========================================
Files 62 66 +4
Lines 2402 2498 +96
==========================================
+ Hits 2251 2346 +95
- Misses 151 152 +1 ☔ View full report in Codecov by Sentry. |
PipKat
reviewed
Mar 14, 2024
PipKat
reviewed
Mar 14, 2024
PipKat
reviewed
Mar 14, 2024
PipKat
reviewed
Mar 14, 2024
PipKat
reviewed
Mar 14, 2024
PipKat
reviewed
Mar 14, 2024
…vel/interrupt-example # Conflicts: # examples/mapdl_tyre_performance/interrupt_task.py
PipKat
reviewed
Mar 15, 2024
PipKat
reviewed
Mar 18, 2024
|
@PipKat the Documentation build fails due to "404 Not Found [IP: 52.252.163.49 80]". Are you familiar with that issue? |
…vel/interrupt-example
for more information, see https://pre-commit.ci
PipKat
reviewed
May 21, 2024
| @@ -64,19 +64,28 @@ def interrupt_running_task(client, project_id) -> Project: | |||
| resp = client.session.get(command_defs_url) | |||
| command_defs = resp.json()["task_command_definitions"] | |||
| if not command_defs: | |||
| log.info(f"No command definitions found") | |||
| log.error(f"No command definitions found") | |||
There was a problem hiding this comment.
Suggested change
| log.error(f"No command definitions found") | |
| log.error(f"No command definitions are found.") |
Messages must be complete, with a subject AND a verb AND concluding punctuation.
PipKat
reviewed
May 21, 2024
|
|
||
| log.info(f"Command definition id: {command_defs[0]['id']}") | ||
| if not cmd_def: | ||
| log.error(f"Interrupt command not found") |
There was a problem hiding this comment.
Suggested change
| log.error(f"Interrupt command not found") | |
| log.error(f"Interrupt command is not found.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add script to run interrupt command
Checklist
Please complete the following checklist before submitting your pull request: