List default execution scripts #399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 93.91% 93.95% +0.04%
==========================================
Files 66 66
Lines 2498 2515 +17
==========================================
+ Hits 2346 2363 +17
Misses 152 152 ☔ View full report in Codecov by Sentry. |
PipKat
reviewed
May 17, 2024
| @@ -81,14 +82,26 @@ def fs_url(self) -> str: | |||
| self._fs_url = _find_available_fs_url(self.get_storage()) | |||
| return self._fs_url | |||
|
|
|||
| def get_api_info(self): | |||
| def get_api_info(self) -> dict: | |||
| """Get information of the JMS API that the client is connected to. | |||
There was a problem hiding this comment.
Suggested change
| """Get information of the JMS API that the client is connected to. | |
| """Get information on the JMS API that the client is connected to. |
"of the JMS API" didn't read well. Hope "on the JMS API" is OK.
PipKat
reviewed
May 17, 2024
| """Get information of the JMS API that the client is connected to. | ||
|
|
||
| Information includes the version and build date. | ||
| """ | ||
| r = self.client.session.get(self.url) | ||
| return r.json() | ||
|
|
||
| @property | ||
| def api_info(self) -> dict: | ||
| """Information of the JMS API that the client is connected to.""" |
There was a problem hiding this comment.
Suggested change
| """Information of the JMS API that the client is connected to.""" | |
| """Information on the JMS API that the client is connected to.""" |
PipKat
reviewed
May 17, 2024
|
|
||
| You can use the method :meth:`JmsApi.list_default_execution_scripts` to query |
There was a problem hiding this comment.
Suggested change
| You can use the method :meth:`JmsApi.list_default_execution_scripts` to query | |
| You can use the :meth:`JmsApi.list_default_execution_scripts` method to query |
Noun indicating the type of object should follow the tagged code entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.