feat: add globals kwarg to app and adjust ideconfig behavior
#1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
koubaa
reviewed
Jan 3, 2025
| @@ -186,13 +196,19 @@ def __init__(self, db_file=None, private_appdata=False, **kwargs): | |||
| runtime.initialize(self._version) | |||
| connect_warnings(self) | |||
| self._poster = None | |||
| # Set the initialized flag to True | |||
| self._app._initialized = True | |||
|
|
|||
| self._disposed = False | |||
| atexit.register(_dispose_embedded_app, INSTANCES) | |||
| INSTANCES.append(self) | |||
There was a problem hiding this comment.
@klmcadams No need to add a flag. You can check len(INSTANCES)
koubaa
reviewed
Jan 3, 2025
| @@ -218,6 +234,10 @@ def _dispose(self): | |||
| self._app.Dispose() | |||
| self._disposed = True | |||
|
|
|||
| def is_initialized(self): | |||
There was a problem hiding this comment.
this should be a free function. otherwise you need an instance of the app to check if the app is initialized
koubaa
reviewed
Jan 3, 2025
| # SOFTWARE. | ||
| """Import Mechanical globals.""" | ||
|
|
||
| import clr |
There was a problem hiding this comment.
missing the exception here if the app hasn't been initialized yet
|
Need to update examples. one should use the new globals() argument. Another should avoid globals entirely and import the types manually after constructing the app instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalskwarg to App classideconfig