generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fea: adding new PySherlock APIs Layer.list_layers and Layer.export_layer_image #462
Open
ansmedson-ext
wants to merge
13
commits into
main
Choose a base branch
from
medson/listLayers2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated list_layers and export_layer_image in layer.py to raise SherlockNoGrpcConnectionException() instead of returning with an error message.
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Dec 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
- Coverage 60.22% 60.22% -0.01%
==========================================
Files 23 23
Lines 4983 5058 +75
==========================================
+ Hits 3001 3046 +45
- Misses 1982 2012 +30 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added APIs Layer.list_layers and Layer.export_layer_image.
Issue linked
New functionalities.
Checklist:
- Run tests without Sherlock running
- Run tests with Sherlock GRPC connection
- pre-commit command line check
- Problems tab in PyCharm
- Open index.html
- Click on "API Reference" at the top.
- Verify HTML for API changes.
feat: adding new PySherlock command
)