docs: Updated documentation in update potting region. #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 60.22% 60.22%
=======================================
Files 23 23
Lines 4983 4983
=======================================
Hits 3001 3001
Misses 1982 1982 ☔ View full report in Codecov by Sentry. |
|
After this is completed, this commit should be cherry picked to the |
ansjmoody
requested changes
Dec 20, 2024
| update_request1, | ||
| update_request2 | ||
| ] | ||
| ) |
There was a problem hiding this comment.
This line should be outdented.
| update_request2 | ||
| ] | ||
| >>> return_codes = sherlock.layer.update_potting_region(request) | ||
| >>> all_requests = UpdatePottingRegionRequest( |
There was a problem hiding this comment.
How about renaming all_requests to request, since it is a request object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated example for update potting region.
Issue linked
Update potting region example is incorrect #476
Checklist:
- Run tests without Sherlock running
- Run tests with Sherlock GRPC connection
- pre-commit command line check
- Problems tab in PyCharm
- Open index.html
- Click on "API Reference" at the top.
- Verify HTML for API changes.
feat: adding new PySherlock command)