Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supervisor to Dockerfile for process management #322

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add supervisor to Dockerfile for process management #322

wants to merge 3 commits into from

Conversation

muratugureminoglu
Copy link
Contributor

@muratugureminoglu muratugureminoglu commented Dec 10, 2024 •
edited
Loading

@muratugureminoglu muratugureminoglu mentioned this pull request Dec 23, 2024
Open
mekya
mekya requested changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @muratugureminoglu ,

I've some questions and I need some improvements.

Please check and let me know if you have any question or correct me if my requests are not feasible.

docker/Dockerfile_Process
@@ -92,4 +95,23 @@ RUN if [ "true" = "$InstallMediaPush" ]; then \
# Example usage: ./start.sh -e 60


##################### supervisor configuration ##############################
#RUN apt-get update && apt-get install -y supervisor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run these options with a parameter. You can use --build-arg or runtime parameters which one fits better.

Please add some test deployment scripts to make sure that it's working as expected

docker/Dockerfile_Process
#stdout_logfile=/dev/stdout\n\
#stderr_logfile=/dev/stderr' > /etc/supervisor/supervisord.conf
#
#ENTRYPOINT ["/usr/bin/supervisord", "-c", "/etc/supervisor/supervisord.conf"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it receiving the runtime parameters(-g, -s, etc.) as start.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muratugureminoglu @mekya