Merge pull request #8 from ant-media/fix-dash-auto-play

Handle playback_not_allowed error in dash player

src/web_player.js

@@ -945,11 +945,29 @@ export class WebPlayer {
             }
         });
         this.dashPlayer.on(dashjs.MediaPlayer.events.PLAYBACK_ERROR, (event) => {
+            Logger.warn("dash playback error: " + event);
             this.tryNextTech();
         });
         this.dashPlayer.on(dashjs.MediaPlayer.events.ERROR, (event) => {
+            Logger.warn("error: " + event);
             this.tryNextTech();
         });
+
+        this.dashPlayer.on(dashjs.MediaPlayer.events.PLAYBACK_NOT_ALLOWED, (event) => {
+            Logger.warn("dash playback not allowed: " + event);
+            this.handleDashPlayBackNotAllowed();
+        });
+    }
+
+    handleDashPlayBackNotAllowed() {
+        if (!this.forcePlayWithAudio) {
+            Logger.info("Try to play with muted audio");
+            this.dashPlayer.setMute(true);
+            this.dashPlayer.play();
+        }
+        else {
+            this.tryNextTech();
+        }
     }
 
     makeDashPlayerVisibleWhenInitialized() {

test/embedded-player.test.js

@@ -949,9 +949,52 @@ describe("WebPlayer", function() {
 		result = player.sendWebRTCData("data");
 		expect(result).to.be.false;
 		expect(sendDataViaWebRTC.callCount).to.be.equal(1);
+	});
+
+
+	it("handleDashPlayBackNotAllowed", async function(){
+
+	    this.timeout(10000);
+		var videoContainer = document.createElement("video_container");
+
+
+
+		var player = new WebPlayer({
+			streamId:"streamConfig",
+		}, videoContainer, null);
+
+
+		{
+			player.playOrder = ["dash"];
+			await player.initialize().then(()=> {
+
+			}).catch((err) => {
+				expect.fail("it should not fail because we skip videojs and dash is already loaded");
+			});
+		}
+
+		player.dashPlayer = window.dashjs.MediaPlayer().create();
+
+		var setMute = sinon.replace(player.dashPlayer, "setMute", sinon.fake());
+		var play = sinon.replace(player.dashPlayer, "play", sinon.fake());
+		var nextTech = sinon.replace(player, "tryNextTech", sinon.fake());
+
+		expect(player.forcePlayWithAudio).to.be.false;
+		player.handleDashPlayBackNotAllowed();
+		expect(setMute.calledOnce).to.be.true;
+		expect(play.calledOnce).to.be.true;
+		expect(nextTech.notCalled).to.be.true;
+
+		expect(setMute.calledWithExactly(true)).to.be.true;
+
+
+		player.forcePlayWithAudio = true;
+		player.handleDashPlayBackNotAllowed();
+		expect(setMute.calledOnce).to.be.true;
+		expect(play.calledOnce).to.be.true;
+		expect(nextTech.calledOnce).to.be.true;
+
 
-
-
 
 	});