Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rotation logic from onFrame to OrientationEventListener #28

Merged
merged 18 commits into from
Nov 22, 2023

Conversation

mustafaboleken
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7d4eb04) 16.95% compared to head (b9b5800) 11.75%.

Files Patch % Lines
...rc/main/java/org/webrtc/ScreenCapturerAndroid.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
- Coverage     16.95%   11.75%   -5.21%     
+ Complexity      447      285     -162     
============================================
  Files           178      155      -23     
  Lines         13180    11419    -1761     
  Branches       1408     1334      -74     
============================================
- Hits           2235     1342     -893     
+ Misses        10731     9889     -842     
+ Partials        214      188      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burak-58 burak-58 merged commit cb09edb into master Nov 22, 2023
3 of 4 checks passed
@burak-58 burak-58 deleted the fix/issue-5214 branch November 22, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android SDK] Rotation issue during screen share
2 participants